Changeset 27649

Timestamp:

03/21/2014 09:03:59 PM (12 years ago)

Author:

ocean90

Message:

Themes: Improve RegExp pattern for search.

• The replacement of spaces is now done globally.
• The search term is now escaped for RegExp meta characters.

props westonruter for the hint.
fixes #27479.

File:

• trunk/src/wp-admin/js/theme.js (modified) (1 diff)

trunk/src/wp-admin/js/theme.js

@@ -180 +180 @@
         this.reset( themes.data.themes, { silent: true } );
 
-        // The RegExp object to match
-        //
+        // Escape the term string for RegExp meta characters
+        term = term.replace( /[-\/\\^$*+?.()|[\]{}]/g, '\\$&' );
+
         // Consider spaces as word delimiters and match the whole string
         // so matching terms can be combined
-        term = term.replace( ' ', ')(?=.*' );
+        term = term.replace( / /g, ')(?=.*' );
         match = new RegExp( '^(?=.*' + term + ').+', 'i' );