Changeset 27657

Timestamp:

03/23/2014 02:34:39 AM (11 years ago)

Author:

wonderboymusic

Message:

Turn on thumbnail support for attachment:audio and attachment:video. Change conditionals to check for theme OR post type support when determining whether to turn on the Featured Image UI pieces in the admin.

Fixes #27460.

Location:

trunk/src

Files:

• wp-admin/edit-form-advanced.php (modified) (2 diffs)
• wp-admin/includes/image.php (modified) (1 diff)
• wp-includes/media.php (modified) (1 diff)
• wp-includes/post.php (modified) (1 diff)

trunk/src/wp-admin/edit-form-advanced.php

@@ -25 +25 @@
 $action = isset($action) ? $action : '';
 
-$media_type = false;
-if ( 'attachment' === $post_type && $post_ID ) {
-    $post = get_post( $post_ID );
-    $media_type = post_supports_thumbnails( $post );
-}
-
-if ( post_type_supports( $post_type, 'editor' ) || post_type_supports( $post_type, 'thumbnail' ) || $media_type ) {
+$media_support = theme_supports_thumbnails( $post ) || post_supports_thumbnails( $post );
+
+if ( post_type_supports( $post_type, 'editor' ) || post_type_supports( $post_type, 'thumbnail' ) || $media_support ) {
     add_thickbox();
     wp_enqueue_media( array( 'post' => $post_ID ) );
@@ -170 +166 @@
     add_meta_box('pageparentdiv', 'page' == $post_type ? __('Page Attributes') : __('Attributes'), 'page_attributes_meta_box', null, 'side', 'core');
 
-$audio_post_support = $video_post_support = false;
-$theme_support = current_theme_supports( 'post-thumbnails', $post_type ) && post_type_supports( $post_type, 'thumbnail' );
-if ( 'attachment' === $post_type && ! empty( $post->post_mime_type ) ) {
-    $audio_post_support = 0 === strpos( $post->post_mime_type, 'audio/' ) && current_theme_supports( 'post-thumbnails', 'attachment:audio' ) && post_type_supports( 'attachment:audio', 'thumbnail' );
-    $video_post_support = 0 === strpos( $post->post_mime_type, 'video/' ) && current_theme_supports( 'post-thumbnails', 'attachment:video' ) && post_type_supports( 'attachment:video', 'thumbnail' );
-}
-
-if ( $theme_support || $audio_post_support || $video_post_support )
+if ( current_theme_supports( 'post-thumbnails', $post_type ) || post_supports_thumbnails( $post ) )
     add_meta_box('postimagediv', __('Featured Image'), 'post_thumbnail_meta_box', null, 'side', 'low');
 

trunk/src/wp-admin/includes/image.php

@@ -128 +128 @@
     } elseif ( preg_match( '#^video/#', get_post_mime_type( $attachment ) ) ) {
         $metadata = wp_read_video_metadata( $file );
-        $support = current_theme_supports( 'post-thumbnails', 'attachment:video' ) && post_type_supports( 'attachment:video', 'thumbnail' );
+        $support = current_theme_supports( 'post-thumbnails', 'attachment:video' ) || post_type_supports( 'attachment:video', 'thumbnail' );
     } elseif ( preg_match( '#^audio/#', get_post_mime_type( $attachment ) ) ) {
         $metadata = wp_read_audio_metadata( $file );
-        $support = current_theme_supports( 'post-thumbnails', 'attachment:audio' ) && post_type_supports( 'attachment:audio', 'thumbnail' );
+        $support = current_theme_supports( 'post-thumbnails', 'attachment:audio' ) || post_type_supports( 'attachment:audio', 'thumbnail' );
     }
 

trunk/src/wp-includes/media.php

@@ -2446 +2446 @@
         );
 
-        if ( theme_supports_thumbnails( $post ) && post_supports_thumbnails( $post ) ) {
+        if ( theme_supports_thumbnails( $post ) || post_supports_thumbnails( $post ) ) {
             $featured_image_id = get_post_meta( $post->ID, '_thumbnail_id', true );
             $settings['post']['featuredImageId'] = $featured_image_id ? $featured_image_id : -1;

trunk/src/wp-includes/post.php

@@ -75 +75 @@
         'supports' => array( 'title', 'author', 'comments' ),
     ) );
+    add_post_type_support( 'attachment:audio', 'thumbnail' );
+    add_post_type_support( 'attachment:video', 'thumbnail' );
 
     register_post_type( 'revision', array(