Changeset 27668

Timestamp:

03/24/2014 02:04:56 AM (9 years ago)

Author:

nacin

Message:

Introduce HTML5 caption support.

When a theme supports HTML5 captions via add_theme_support( 'html5', 'caption' ), figure and figcaption will be used instead of div and p.

There's a bonus. But first, some history: Captions were introduced with an inline style set for the container. This remains, as it is there to force captions to wrap. But this inline style included an extra 10 pixels, which have vexxed theme developers for years. While these pixels were designed to ensure padding around floated images, modern themes handle this with grace. The additional pixels thus feel encumbering.

As the new HTML5 gallery support avoids outputting default gallery styles (again, irking theme developers for years; see #26697), the new HTML5 caption support will also ditch these 10 pixels of unwanted hand-holding.

The 10 pixels are also removed entirely in the visual editor (and more styles may also disappear here; see #26642), giving themes the power necessary to match the frontend styles.

The filter img_caption_shortcode_width added in 3.7 to work around this madness (see #14380) is skipped entirely when the theme supports HTML5 captions.

props obenland, azaozz.
see #26642. also fixes #9066.

Location:

trunk/src/wp-includes

Files:

• class-wp-editor.php (modified) (1 diff)
• js/tinymce/plugins/wpeditimage/plugin.js (modified) (7 diffs)
• js/tinymce/skins/wordpress/wp-content.css (modified) (1 diff)
• media.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-editor.php

@@ -340 +340 @@
 
                     'wpeditimage_disable_captions' => $no_captions,
+                    'wpeditimage_html5_captions' => current_theme_supports( 'html5', 'caption' ),
                     'plugins' => implode( ',', $plugins ),
                 );

trunk/src/wp-includes/js/tinymce/plugins/wpeditimage/plugin.js

@@ -48 +48 @@
             }
 
-            width = parseInt( w, 10 ) + 10;
+            width = parseInt( w, 10 );
+            if ( ! editor.getParam( 'wpeditimage_html5_captions' ) ) {
+                width += 10;
+            }
 
             return '<div class="mceTemp"><dl id="'+ id +'" class="wp-caption '+ cls +'" style="width: '+ width +'px">' +
@@ -190 +193 @@
             html = createImageAndLink( imageData, 'html' );
 
-            width = imageData.width + 10;
+            width = parseInt( imageData.width );
+
+            if ( ! editor.getParam( 'wpeditimage_html5_captions' ) ) {
+                width += 10;
+            }
+
             className = 'align' + imageData.align;
 
@@ -391 +399 @@
     editor.on( 'init', function() {
         var dom = editor.dom;
+
+        if ( editor.getParam( 'wpeditimage_html5_captions' ) ) {
+            dom.addClass( editor.getBody(), 'html5-captions' );
+        }
 
         // Add caption field to the default image dialog
@@ -476 +488 @@
 
                     if ( data.width ) {
-                        captionWidth = parseInt( data.width, 10 ) + 10;
-                        captionWidth = ' style="width: '+ captionWidth +'px"';
+                        captionWidth = parseInt( data.width, 10 );
+
+                        if ( ! editor.getParam( 'wpeditimage_html5_captions' ) ) {
+                            captionWidth += 10;
+                        }
+
+                        captionWidth = ' style="width: ' + captionWidth + 'px"';
                     }
 
@@ -540 +557 @@
 
                         if ( captionWidth ) {
-                            captionWidth = parseInt( captionWidth, 10 ) + 10;
+                            captionWidth = parseInt( captionWidth, 10 );
+
+                            if ( ! editor.getParam( 'wpeditimage_html5_captions' ) ) {
+                                captionWidth += 10;
+                            }
+
                             captionWidth = ' style="width: '+ captionWidth +'px"';
                         }
@@ -619 +641 @@
             // Remove toolbar to avoid an orphaned toolbar when dragging an image to a new location
             removeToolbar();
-
         });
 
@@ -655 +676 @@
 
                 if ( width ) {
-                    width = parseInt( width, 10 ) + 10;
+                    width = parseInt( width, 10 );
+
+                    if ( ! editor.getParam( 'wpeditimage_html5_captions' ) ) {
+                        width += 10;
+                    }
+
                     editor.dom.setStyle( parent, 'width', width + 'px' );
                 }

trunk/src/wp-includes/js/tinymce/skins/wordpress/wp-content.css

@@ -39 +39 @@
     padding-top: 4px;
     margin: 10px 0;
+}
+
+.html5-captions .wp-caption {
+    padding: 4px;
 }
 

trunk/src/wp-includes/media.php

@@ -766 +766 @@
         $atts['id'] = 'id="' . esc_attr( $atts['id'] ) . '" ';
 
+    $class = trim( 'wp-caption ' . $atts['align'] . ' ' . $atts['class'] );
+
+    if ( current_theme_supports( 'html5', 'caption' ) ) {
+        return '<figure ' . $atts['id'] . 'style="width: ' . (int) $atts['width'] . 'px;" class="' . esc_attr( $class ) . '">'
+        . do_shortcode( $content ) . '<figcaption class="wp-caption-text">' . $atts['caption'] . '</figcaption></figure>';
+    }
+
     $caption_width = 10 + $atts['width'];
 
@@ -788 +795 @@
     if ( $caption_width )
         $style = 'style="width: ' . (int) $caption_width . 'px" ';
-
-    $class = trim( 'wp-caption ' . $atts['align'] . ' ' . $atts['class'] );
 
     return '<div ' . $atts['id'] . $style . 'class="' . esc_attr( $class ) . '">'