Changeset 27686

Timestamp:

03/24/2014 06:54:38 PM (11 years ago)

Author:

wonderboymusic

Message:

When using WP_Query's "fields" => "ids" (or "fields" => "id=>parent"), the returned values should be an array of integers, not array of integers represented by strings.

Adds unit tests. All other unit tests pass.

Props danielbachhuber.
Fixes #27252.

Location:

trunk

Files:

• src/wp-includes/query.php (modified) (3 diffs)
• tests/phpunit/tests/query/results.php (modified) (2 diffs)

trunk/src/wp-includes/query.php

@@ -2269 +2269 @@
             if ( ! empty( $q['posts_per_rss'] ) ) {
                 $q['posts_per_page'] = $q['posts_per_rss'];
-            } else { 
+            } else {
                 $q['posts_per_page'] = get_option( 'posts_per_rss' );
             }
@@ -3206 +3206 @@
             $this->set_found_posts( $q, $limits );
 
-            return $this->posts;
+            return array_map( 'intval', $this->posts );
         }
 
@@ -3215 +3215 @@
 
             $r = array();
-            foreach ( $this->posts as $post )
-                $r[ $post->ID ] = $post->post_parent;
-
+            foreach ( $this->posts as $post ) {
+                $r[ (int) $post->ID ] = (int) $post->post_parent;
+            }
             return $r;
         }

trunk/tests/phpunit/tests/query/results.php

@@ -47 +47 @@
         $this->parent_two = $this->factory->post->create( array( 'post_title' => 'parent-two', 'post_date' => '2007-01-01 00:00:00' ) );
         $this->parent_three = $this->factory->post->create( array( 'post_title' => 'parent-three', 'post_date' => '2007-01-01 00:00:00' ) );
-        $this->factory->post->create( array( 'post_title' => 'child-one', 'post_parent' => $this->parent_one, 'post_date' => '2007-01-01 00:00:01' ) );
-        $this->factory->post->create( array( 'post_title' => 'child-two', 'post_parent' => $this->parent_one, 'post_date' => '2007-01-01 00:00:02' ) );
-        $this->factory->post->create( array( 'post_title' => 'child-three', 'post_parent' => $this->parent_two, 'post_date' => '2007-01-01 00:00:03' ) );
-        $this->factory->post->create( array( 'post_title' => 'child-four', 'post_parent' => $this->parent_two, 'post_date' => '2007-01-01 00:00:04' ) );
+        $this->child_one = $this->factory->post->create( array( 'post_title' => 'child-one', 'post_parent' => $this->parent_one, 'post_date' => '2007-01-01 00:00:01' ) );
+        $this->child_two = $this->factory->post->create( array( 'post_title' => 'child-two', 'post_parent' => $this->parent_one, 'post_date' => '2007-01-01 00:00:02' ) );
+        $this->child_three = $this->factory->post->create( array( 'post_title' => 'child-three', 'post_parent' => $this->parent_two, 'post_date' => '2007-01-01 00:00:03' ) );
+        $this->child_four = $this->factory->post->create( array( 'post_title' => 'child-four', 'post_parent' => $this->parent_two, 'post_date' => '2007-01-01 00:00:04' ) );
 
         unset( $this->q );
@@ -371 +371 @@
     }
 
+    /**
+     * @ticket 27252
+     */
+    function test_query_fields_integers() {
+
+        $parents = array(
+            (int) $this->parent_one,
+            (int) $this->parent_two
+        );
+        $posts1 = $this->q->query( array(
+            'post__in'  => $parents,
+            'fields'    => 'ids',
+            'orderby'   => 'post__in',
+        ) );
+
+        $this->assertSame( $parents, $posts1 );
+
+        $children = array(
+            (int) $this->child_one => (int) $this->parent_one,
+            (int) $this->child_two => (int) $this->parent_one
+        );
+
+        $posts2 = $this->q->query( array(
+            'post__in'  => array_keys( $children ),
+            'fields'    => 'id=>parent',
+            'orderby'   => 'post__in',
+        ) );
+
+        $this->assertSame( $children, $posts2 );
+
+    }
+
     function test_exlude_from_search_empty() {
         global $wp_post_types;