Changeset 27764

Timestamp:

03/27/2014 12:06:50 AM (11 years ago)

Author:

azaozz

Message:

Add the 'attachment_' prefix to caption IDs after editing, see #24409

File:

• trunk/src/wp-includes/js/tinymce/plugins/wpeditimage/plugin.js (modified) (2 diffs)

trunk/src/wp-includes/js/tinymce/plugins/wpeditimage/plugin.js

@@ -187 +187 @@
 
     function updateImage( imageNode, imageData ) {
-        var className, width, node, html, captionNode, nodeToReplace, uid, editedImg;
+        var className, width, node, html, captionNode, nodeToReplace, uid, editedImg, id;
 
         if ( imageData.caption ) {
@@ -200 +200 @@
 
             className = 'align' + imageData.align;
-
-            //TODO: shouldn't add the id attribute if it isn't an attachment
+            id = imageData.attachment_id ? 'id="attachment_'+ imageData.attachment_id +'" ' : '';
 
             // should create a new function for generating the caption markup
-            html =  '<dl id="'+ imageData.attachment_id +'" class="wp-caption '+ className +'" style="width: '+ width +'px">' +
+            html =  '<dl ' + id + 'class="wp-caption '+ className +'" style="width: '+ width +'px">' +
                 '<dt class="wp-caption-dt">'+ html + '</dt><dd class="wp-caption-dd">'+ imageData.caption +'</dd></dl>';