Changeset 27776

Timestamp:

03/27/2014 06:55:51 AM (11 years ago)

Author:

nacin

Message:

Proper IDs for the custom fields box.

props SergeyBiryukov.
fixes #14376.

File:

• trunk/src/wp-admin/includes/template.php (modified) (4 diffs)

trunk/src/wp-admin/includes/template.php

@@ -567 +567 @@
 
     $r .= "\n\t<tr id='meta-{$entry['meta_id']}' class='$style'>";
-    $r .= "\n\t\t<td class='left'><label class='screen-reader-text' for='meta[{$entry['meta_id']}][key]'>" . __( 'Key' ) . "</label><input name='meta[{$entry['meta_id']}][key]' id='meta[{$entry['meta_id']}][key]' type='text' size='20' value='{$entry['meta_key']}' />";
+    $r .= "\n\t\t<td class='left'><label class='screen-reader-text' for='meta-{$entry['meta_id']}-key'>" . __( 'Key' ) . "</label><input name='meta[{$entry['meta_id']}][key]' id='meta-{$entry['meta_id']}-key' type='text' size='20' value='{$entry['meta_key']}' />";
 
     $r .= "\n\t\t<div class='submit'>";
@@ -577 +577 @@
     $r .= "</td>";
 
-    $r .= "\n\t\t<td><label class='screen-reader-text' for='meta[{$entry['meta_id']}][value]'>" . __( 'Value' ) . "</label><textarea name='meta[{$entry['meta_id']}][value]' id='meta[{$entry['meta_id']}][value]' rows='2' cols='30'>{$entry['meta_value']}</textarea></td>\n\t</tr>";
+    $r .= "\n\t\t<td><label class='screen-reader-text' for='meta-{$entry['meta_id']}-value'>" . __( 'Value' ) . "</label><textarea name='meta[{$entry['meta_id']}][value]' id='meta-{$entry['meta_id']}-value' rows='2' cols='30'>{$entry['meta_value']}</textarea></td>\n\t</tr>";
     return $r;
 }
@@ -608 +608 @@
         ORDER BY meta_key
         LIMIT $limit" );
-    if ( $keys )
-        natcasesort($keys);
+    if ( $keys ) {
+        natcasesort( $keys );
+        $meta_key_input_id = 'metakeyselect';
+    } else {
+        $meta_key_input_id = 'metakeyinput';
+    }
 ?>
 <p><strong><?php _e( 'Add New Custom Field:' ) ?></strong></p>
@@ -615 +619 @@
 <thead>
 <tr>
-<th class="left"><label for="metakeyselect"><?php _ex( 'Name', 'meta name' ) ?></label></th>
+<th class="left"><label for="<?php echo $meta_key_input_id; ?>"><?php _ex( 'Name', 'meta name' ) ?></label></th>
 <th><label for="metavalue"><?php _e( 'Value' ) ?></label></th>
 </tr>