Changeset 27794 for trunk/src/wp-includes/class-wp-image-editor.php

Timestamp:

03/27/2014 08:39:08 PM (12 years ago)

Author:

wonderboymusic

Message:

In multi_resize() image editor methods, assert that null can only be passed for one of the arguments, not both. Add a lot more unit test assertions to ensure this.

Props pbearne, DH-Shredder.
Fixes #26823.

File:

• trunk/src/wp-includes/class-wp-image-editor.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-image-editor.php

@@ -83 +83 @@
      * Resizes current image.
      *
-     * @since 3.5.0
-     * @access public
-     * @abstract
-     *
-     * @param int $max_w
-     * @param int $max_h
-     * @param boolean $crop
+     * At minimum, either a height or width must be provided.
+     * If one of the two is set to null, the resize will
+     * maintain aspect ratio according to the provided dimension.
+     *
+     * @since 3.5.0
+     * @access public
+     * @abstract
+     *
+     * @param  int|null $max_w Image width.
+     * @param  int|null $max_h Image height.
+     * @param  boolean  $crop
      * @return boolean|WP_Error
      */