Changeset 27961

Timestamp:

04/05/2014 08:27:56 PM (6 years ago)

Author:

nacin

Message:

Theme Installer: Use JSONP for api.wordpress.org requests.

fixes #27639.

File:

• trunk/src/wp-admin/js/theme.js (modified) (2 diffs)

trunk/src/wp-admin/js/theme.js

@@ -318 +318 @@
     },
 
-    // Send Ajax POST request to api.wordpress.org/themes
+    // Send request to api.wordpress.org/themes
     apiCall: function( request, paginated ) {
 
-        // Ajax request to .org API
+        // Send tags (and fields) as comma-separated to keep the JSONP query string short.
+        if ( request.tag && _.isArray( request.tag ) ) {
+            request.tag = request.tag.join( ',' );
+        }
+
+        // JSONP request to .org API
         return $.ajax({
-            url: 'https://api.wordpress.org/themes/info/1.1/?action=query_themes',
-
-            // We want JSON data
-            dataType: 'json',
-            type: 'POST',
-            crossDomain: true,
+            url: 'https://api.wordpress.org/themes/info/1.1/?callback=?',
+            dataType: 'jsonp',
 
             // Request data
@@ -335 +336 @@
                 request: _.extend({
                     per_page: 72,
-                    fields: {
-                        description: true,
-                        tested: true,
-                        requires: true,
-                        rating: true,
-                        downloaded: true,
-                        downloadLink: true,
-                        last_updated: true,
-                        homepage: true,
-                        num_ratings: true
-                    }
+                    fields: 'description,tested,requires,rating,downloaded,downloadLink,last_updated,homepage,num_ratings'
                 }, request)
             },