WordPress.org

Make WordPress Core

Changeset 27963


Ignore:
Timestamp:
04/05/2014 08:45:37 PM (5 years ago)
Author:
nacin
Message:

Theme Installer: Separate API from an event handler to avoid issues where a false return value stops the event.

see #27055.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/js/theme.js

    r27961 r27963  
    12371237        'click .theme-filter': 'onFilter',
    12381238        'click .more-filters': 'moreFilters',
    1239         'click .apply-filters': 'addFilter',
    1240         'click [type="checkbox"]': 'filtersChecked',
     1239        'click .apply-filters': 'applyFilters',
     1240        'click [type="checkbox"]': 'addFilter',
    12411241        'click .clear-filters': 'clearFilters',
    12421242        'click .feature-name': 'filterSection',
     
    13661366    },
    13671367
    1368     // Clicking on a checkbox triggers a tag request
    1369     addFilter: function( event ) {
     1368    // Clicking on a checkbox to add another filter to the request
     1369    addFilter: function() {
     1370        this.filtersChecked();
     1371    },
     1372
     1373    // Applying filters triggers a tag request
     1374    applyFilters: function( event ) {
    13701375        var name,
    13711376            tags = this.filtersChecked(),
Note: See TracChangeset for help on using the changeset viewer.