Changeset 27963

Timestamp:

04/05/2014 08:45:37 PM (13 years ago)

Author:

nacin

Message:

Theme Installer: Separate API from an event handler to avoid issues where a false return value stops the event.

see #27055.

File:

• trunk/src/wp-admin/js/theme.js (modified) (2 diffs)

trunk/src/wp-admin/js/theme.js

@@ -1237 +1237 @@
                 'click .theme-filter': 'onFilter',
                 'click .more-filters': 'moreFilters',
-                'click .apply-filters': 'addFilter',
-                'click [type="checkbox"]': 'filtersChecked',
+                'click .apply-filters': 'applyFilters',
+                'click [type="checkbox"]': 'addFilter',
                 'click .clear-filters': 'clearFilters',
                 'click .feature-name': 'filterSection',
@@ -1366 +1366 @@
         },
 
-        // Clicking on a checkbox triggers a tag request
-        addFilter: function( event ) {
+        // Clicking on a checkbox to add another filter to the request
+        addFilter: function() {
+                this.filtersChecked();
+        },
+
+        // Applying filters triggers a tag request
+        applyFilters: function( event ) {
                 var name,
                         tags = this.filtersChecked(),