Changeset 27964

Timestamp:

04/05/2014 09:18:44 PM (11 years ago)

Author:

nacin

Message:

Better checks for contributors when saving posts.

props dd32, kovshenin, plocha.
see #27452.

Location:

trunk/src/wp-admin/includes

Files:

• class-wp-posts-list-table.php (modified) (1 diff)
• post.php (modified) (8 diffs)

trunk/src/wp-admin/includes/class-wp-posts-list-table.php

@@ -979 +979 @@
     endif; // post_type_supports author
 
-    if ( !$bulk ) :
+    if ( !$bulk && $can_publish ) :
     ?>
 

trunk/src/wp-admin/includes/post.php

@@ -87 +87 @@
             $post_data['post_status'] = 'draft';
         }
+
+        if ( ! get_post_status_object( $post_data['post_status'] ) ) {
+            unset( $post_data['post_status'] );
+        }
     }
 
@@ -107 +111 @@
     $previous_status = $post_id ? get_post_field( 'post_status', $post_id ) : false;
 
+    if ( isset( $post_data['post_status'] ) && 'private' == $post_data['post_status'] && ! current_user_can( $ptype->cap->publish_posts ) ) {
+        $post_data['post_status'] = $previous_status ? $previous_status : 'pending';
+    }
+
     $published_statuses = array( 'publish', 'future' );
 
@@ -117 +125 @@
     if ( ! isset( $post_data['post_status'] ) ) {
         $post_data['post_status'] = 'auto-draft' === $previous_status ? 'draft' : $previous_status;
+    }
+
+    if ( isset( $post_data['post_password'] ) && ! current_user_can( $ptype->cap->publish_posts ) ) {
+        unset( $post_data['post_password'] );
     }
 
@@ -178 +190 @@
     $post_data['post_mime_type'] = $post->post_mime_type;
 
+    if ( ! empty( $post_data['post_status'] ) ) {
+        $post_data['post_status'] = sanitize_key( $post_data['post_status'] );
+
+        if ( 'inherit' == $post_data['post_status'] ) {
+            unset( $post_data['post_status'] );
+        }
+    }
+
     $ptype = get_post_type_object($post_data['post_type']);
     if ( !current_user_can( 'edit_post', $post_ID ) ) {
@@ -194 +214 @@
             _wp_upgrade_revisions_of_post( $post, wp_get_post_revisions( $post_ID ) );
     }
-
-    $post_data = _wp_translate_postdata( true, $post_data );
-    if ( is_wp_error($post_data) )
-        wp_die( $post_data->get_error_message() );
 
     if ( isset($post_data['visibility']) ) {
@@ -215 +231 @@
     }
 
+    $post_data = _wp_translate_postdata( true, $post_data );
+    if ( is_wp_error($post_data) )
+        wp_die( $post_data->get_error_message() );
+
     // Post Formats
     if ( isset( $post_data['post_format'] ) )
@@ -351 +371 @@
     }
     unset($post_data['_status']);
+
+    if ( ! empty( $post_data['post_status'] ) ) {
+        $post_data['post_status'] = sanitize_key( $post_data['post_status'] );
+
+        if ( 'inherit' == $post_data['post_status'] ) {
+            unset( $post_data['post_status'] );
+        }
+    }
 
     $post_IDs = array_map( 'intval', (array) $post_data['post'] );
@@ -442 +470 @@
         }
 
+        $post_data['post_type'] = $post->post_type;
         $post_data['post_mime_type'] = $post->post_mime_type;
         $post_data['guid'] = $post->guid;
 
+        foreach ( array( 'comment_status', 'ping_status', 'post_author' ) as $field ) {
+            if ( ! isset( $post_data[ $field ] ) ) {
+                $post_data[ $field ] = $post->$field;
+            }
+        }
+
         $post_data['ID'] = $post_ID;
+        $post_data['post_ID'] = $post_ID;
+
+        $post_data = _wp_translate_postdata( true, $post_data );
+        if ( is_wp_error( $post_data ) ) {
+            $skipped[] = $post_ID;
+            continue;
+        }
+
         $updated[] = wp_update_post( $post_data );