Changeset 28012

Timestamp:

04/07/2014 09:34:18 PM (11 years ago)

Author:

azaozz

Message:

TinyMCE: show an error in the console when a plugin attempts to use the 'wpdialogs' plugin but wpdialog.js is not enqueued, fixes #16284

File:

• trunk/src/wp-includes/js/tinymce/plugins/wpdialogs/plugin.js (modified) (2 diffs)

trunk/src/wp-includes/js/tinymce/plugins/wpdialogs/plugin.js

@@ -30 +30 @@
         }
 
+        if ( typeof jQuery === 'undefined' || ! jQuery.wp || ! jQuery.wp.wpdialog ) {
+            // wpdialod.js is not loaded
+            if ( window.console && window.console.error ) {
+                window.console.error('wpdialog.js is not loaded. Please set it as dependency for your script when calling wp_enqueue_script().');
+            }
+
+            return;
+        }
+
         wp.$element = $element = jQuery( '#' + args.id );
 
@@ -36 +45 @@
         }
 
-        if ( window && window.console ) {
+        if ( window.console && window.console.log ) {
             window.console.log('tinymce.WPWindowManager is deprecated. Use the default editor.windowManager to open dialogs with inline HTML.');
         }