Changeset 28113

Timestamp:

04/14/2014 07:47:10 AM (9 years ago)

Author:

nacin

Message:

Avoid stomping of bulk postdata inside the bulk_edit_posts() loop.

Reverts [27990] which did not fix it for authors and comment/ping status.

props dd32, DrewAPicture.
fixes #27792.

Location:

trunk

Files:

• src/wp-admin/includes/post.php (modified) (2 diffs)
• tests/phpunit/tests/admin/includesPost.php (modified) (4 diffs)

trunk/src/wp-admin/includes/post.php

@@ -434 +434 @@
 
     $updated = $skipped = $locked = array();
+    $shared_post_data = $post_data;
+
     foreach ( $post_IDs as $post_ID ) {
+        // Start with fresh post data with each iteration.
+        $post_data = $shared_post_data;
+
         $post_type_object = get_post_type_object( get_post_type( $post_ID ) );
 
@@ -483 +488 @@
         $post_data['post_ID'] = $post_ID;
 
-        $translated_post_data = _wp_translate_postdata( true, $post_data );
-        if ( is_wp_error( $translated_post_data ) ) {
+        $post_data = _wp_translate_postdata( true, $post_data );
+        if ( is_wp_error( $post_data ) ) {
             $skipped[] = $post_ID;
             continue;
         }
 
-        $updated[] = wp_update_post( $translated_post_data );
+        $updated[] = wp_update_post( $post_data );
 
         if ( isset( $post_data['sticky'] ) && current_user_can( $ptype->cap->edit_others_posts ) ) {

trunk/tests/phpunit/tests/admin/includesPost.php

@@ -5 +5 @@
  */
 class Tests_Admin_includesPost extends WP_UnitTestCase {
+
+    function tearDown() {
+        wp_set_current_user( 0 );
+        parent::tearDown();
+    }
 
     function test__wp_translate_postdata_cap_checks_contributor() {
@@ -57 +62 @@
         $this->assertEquals( 'edit_others_posts', $_results->get_error_code() );
         $this->assertEquals( 'You are not allowed to edit posts as this user.', $_results->get_error_message() );
-
-        wp_set_current_user( 0 );
     }
 
@@ -112 +115 @@
         $this->assertEquals( $_post_data['post_author'], $_results['post_author'] );
         $this->assertEquals( 'draft', $_results['post_status'] );
-
-        wp_set_current_user( 0 );
     }
 
@@ -134 +135 @@
         edit_post( $post_data );
         $this->assertEquals( 'draft', get_post( $post->ID )->post_status );
-        wp_set_current_user( 0 );
+    }
+
+    /**
+     * @ticket 27792
+     */
+    function test_bulk_edit_posts_stomping() {
+        $admin = $this->factory->user->create( array( 'role' => 'administrator' ) );
+        $users = $this->factory->user->create_many( 2, array( 'role' => 'author' ) );
+        wp_set_current_user( $admin );
+
+        $post1 = $this->factory->post->create( array(
+            'post_author'    => $users[0],
+            'comment_status' => 'open',
+            'ping_status'    => 'open',
+            'post_status'    => 'publish',
+        ) );
+
+        $post2 = $this->factory->post->create( array(
+            'post_author'    => $users[1],
+            'comment_status' => 'closed',
+            'ping_status'    => 'closed',
+            'post_status'    => 'draft',
+        ) );
+
+        $request = array(
+            'post_type'        => 'post',
+            'post_author'      => -1,
+            'ping_status'      => -1,
+            'comment_status'   => -1,
+            '_status'          => -1,
+            'post'             => array( $post1, $post2 ),
+        );
+
+        $done = bulk_edit_posts( $request );
+
+        $post = get_post( $post2 );
+
+        // Check that the first post's values don't stomp the second post.
+        $this->assertEquals( 'draft', $post->post_status );
+        $this->assertEquals( $users[1], $post->post_author );
+        $this->assertEquals( 'closed', $post->comment_status );
+        $this->assertEquals( 'closed', $post->ping_status );
     }