Changeset 28115 for branches/3.7/src

Timestamp:

04/14/2014 08:12:42 AM (11 years ago)

Author:

nacin

Message:

Avoid stomping of bulk postdata inside the bulk_edit_posts() loop.

Merges [28113] to the 3.7 branch.

Reverts [27992] which did not fix it for authors and comment/ping status.

props dd32, DrewAPicture.
fixes #27792.

Location:

branches/3.7

Files:

• . (modified) (1 prop)
• src (modified) (1 prop)
• src/wp-admin/includes/post.php (modified) (2 diffs)

branches/3.7/src/wp-admin/includes/post.php

@@ -412 +412 @@
 
     $updated = $skipped = $locked = array();
+    $shared_post_data = $post_data;
+
     foreach ( $post_IDs as $post_ID ) {
+        // Start with fresh post data with each iteration.
+        $post_data = $shared_post_data;
+
         $post_type_object = get_post_type_object( get_post_type( $post_ID ) );
 
@@ -461 +466 @@
         $post_data['post_ID'] = $post_ID;
 
-        $translated_post_data = _wp_translate_postdata( true, $post_data );
-        if ( is_wp_error( $translated_post_data ) ) {
+        $post_data = _wp_translate_postdata( true, $post_data );
+        if ( is_wp_error( $post_data ) ) {
             $skipped[] = $post_ID;
             continue;
         }
 
-        $updated[] = wp_update_post( $translated_post_data );
+        $updated[] = wp_update_post( $post_data );
 
         if ( isset( $post_data['sticky'] ) && current_user_can( $ptype->cap->edit_others_posts ) ) {