Changeset 28125

Timestamp:

04/14/2014 11:55:04 PM (12 years ago)

Author:

nacin

Message:

Image Details modal: Remember the last state of the advanced toggle.

props gcorne.
fixes #27366.

File:

• trunk/src/wp-includes/js/media-views.js (modified) (4 diffs)

trunk/src/wp-includes/js/media-views.js

@@ -6227 +6227 @@
                         'click .edit-attachment': 'editAttachment',
                         'click .replace-attachment': 'replaceAttachment',
-                        'click .advanced-toggle': 'toggleAdvanced',
+                        'click .advanced-toggle': 'onToggleAdvanced',
                         'change [data-setting="customWidth"]': 'onCustomSize',
                         'change [data-setting="customHeight"]': 'onCustomSize',
@@ -6239 +6239 @@
                         this.listenTo( this.model, 'change:link', this.toggleLinkSettings );
                         this.listenTo( this.model, 'change:size', this.toggleCustomSize );
+
                         media.view.Settings.AttachmentDisplay.prototype.initialize.apply( this, arguments );
                 },
@@ -6278 +6279 @@
                         setTimeout( _.bind( this.resetFocus, this ), 10 );
                         this.toggleLinkSettings();
+                        if ( getUserSetting( 'advImgDetails' ) === 'show' ) {
+                                this.toggleAdvanced( true );
+                        }
                         this.trigger( 'post-render' );
                 },
@@ -6330 +6334 @@
                 },
 
-                toggleAdvanced: function( event ) {
-                        var $advanced = $( event.target ).closest( '.advanced-section' );
+                onToggleAdvanced: function( event ) {
                         event.preventDefault();
-                        if ( $advanced.hasClass('advanced-visible') ) {
+                        this.toggleAdvanced();
+                },
+
+                toggleAdvanced: function( show ) {
+                        var $advanced = this.$el.find( '.advanced-section' ),
+                                mode;
+
+                        if ( $advanced.hasClass('advanced-visible') || show === false ) {
                                 $advanced.removeClass('advanced-visible');
                                 $advanced.find('.advanced-settings').addClass('hidden');
+                                mode = 'hide';
                         } else {
                                 $advanced.addClass('advanced-visible');
                                 $advanced.find('.advanced-settings').removeClass('hidden');
-                        }
+                                mode = 'show';
+                        }
+
+                        setUserSetting( 'advImgDetails', mode );
                 },