Changeset 28182 for trunk/src/wp-includes/media.php

Timestamp:

04/22/2014 05:52:06 PM (12 years ago)

Author:

wonderboymusic

Message:

Refinements for asynchronous rendering in wp.mce.media.PlaylistView:

• Add visibility: hidden as an inline style to <audio> tags, there is a race with the stylesheet which can get enqueued in the body and loaded in the footer.
• When creating new instances of MediaElementPlayer, always push them onto a stack. Lone views can be responsible for multiple instances of the same shortcode on render.
• Rename wp.media.mixin.unsetPlayer() to wp.media.mixin.unsetPlayers() to reflect the above.
• Call wp.media.mixin.unsetPlayers() on the view's unbind() method, instead of inline in the render() method
• Make sure WPPlaylistView is instantiated for each editor instance
• Ensure that the No Items Found view state is not rendered when attachments actually do exist.

Props gcorne, wonderboymusic.
See #27899.

File:

• trunk/src/wp-includes/media.php (modified) (2 diffs)

trunk/src/wp-includes/media.php

@@ -1354 +1354 @@
     ?>"<?php if ( 'video' === $safe_type ):
         echo ' height="', (int) $theme_height, '"';
+    else:
+        echo ' style="visibility: hidden"';
     endif; ?>></<?php echo $safe_type ?>>
     <div class="wp-playlist-next"></div>
@@ -1556 +1558 @@
         'autoplay' => $autoplay,
         'preload'  => $preload,
-        'style'    => 'width: 100%',
+        'style'    => 'width: 100%; visibility: hidden;',
     );