Changeset 28191

Timestamp:

04/23/2014 10:04:03 PM (10 years ago)

Author:

johnbillion

Message:

Avoid an expensive attachment counting query on the post editing screen. See #27985, for trunk.

Location:

trunk/src/wp-includes

Files:

• media.php (modified) (2 diffs)
• post.php (modified) (1 diff)

trunk/src/wp-includes/media.php

@@ -2696 +2696 @@
     }
 
-    $audio = $video = 0;
-    $counts = (array) wp_count_attachments();
-    foreach ( $counts as $mime => $total ) {
-        if ( 0 === strpos( $mime, 'audio/' ) ) {
-            $audio += (int) $total;
-        } elseif ( 0 === strpos( $mime, 'video/' ) ) {
-            $video += (int) $total;
-        }
-    }
-
     $settings = array(
         'tabs'      => $tabs,
@@ -2720 +2710 @@
         'defaultProps' => $props,
         'attachmentCounts' => array(
-            'audio' => $audio,
-            'video' => $video
+            'audio' => wp_has_mime_type_attachments( 'audio' ) ? 1 : 0,
+            'video' => wp_has_mime_type_attachments( 'video' ) ? 1 : 0
         ),
         'embedExts'    => $exts,

trunk/src/wp-includes/post.php

@@ -2293 +2293 @@
 
 /**
+ * Determine if at least one attachment of a particular mime-type has been uploaded
+ *
+ * @global wpdb $wpdb
+ *
+ * @since 3.9.1
+ *
+ * @param string $mime_type The mime-type string to check.
+ *
+ * @return int|null If exist, the post ID of the first found attachment.
+ */
+function wp_has_mime_type_attachments( $mime_type ) {
+    global $wpdb;
+    $sql = sprintf( "SELECT ID FROM $wpdb->posts WHERE post_type = 'attachment' AND post_mime_type LIKE '%s%%' LIMIT 1", like_escape( $mime_type ) );
+    return $wpdb->get_var( $sql );
+}
+
+/**
  * Get default post mime types
  *