Changeset 28197

Timestamp:

04/24/2014 08:44:32 PM (11 years ago)

Author:

markjaquith

Message:

Force users to choose a nav menu in the custom nav menu widget, for a better customizer UX

Before, they had to make a dummy change to get it to render. Now they
are made to choose a nav menu from the dropdown, which feels more
natural.

fixes #27878 for trunk. props westonruter

File:

• trunk/src/wp-includes/default-widgets.php (modified) (1 diff)

trunk/src/wp-includes/default-widgets.php

@@ -1349 +1349 @@
             <label for="<?php echo $this->get_field_id('nav_menu'); ?>"><?php _e('Select Menu:'); ?></label>
             <select id="<?php echo $this->get_field_id('nav_menu'); ?>" name="<?php echo $this->get_field_name('nav_menu'); ?>">
+                <option value="0"><?php _e( '-- Select --' ) ?></option>
         <?php
             foreach ( $menus as $menu ) {
                 echo '<option value="' . $menu->term_id . '"'
                     . selected( $nav_menu, $menu->term_id, false )
-                    . '>'. $menu->name . '</option>';
+                    . '>'. esc_html( $menu->name ) . '</option>';
             }
         ?>