Changeset 28261 for branches/3.9/src/wp-includes/media.php

Timestamp:

05/06/2014 03:21:56 AM (11 years ago)

Author:

nacin

Message:

Avoid an expensive attachment counting query on the post editing screen.

Merges [28191], [28194] to the 3.9 branch.

props johnbillion.
fixes #27985.

Location:

branches/3.9

Files:

• . (modified) (1 prop)
• src/wp-includes/media.php (modified) (3 diffs)

branches/3.9/src/wp-includes/media.php

@@ -2655 +2655 @@
         return;
 
-    global $content_width;
+    global $content_width, $wpdb;
 
     $defaults = array(
@@ -2694 +2694 @@
     }
 
-    $audio = $video = 0;
-    $counts = (array) wp_count_attachments();
-    foreach ( $counts as $mime => $total ) {
-        if ( 0 === strpos( $mime, 'audio/' ) ) {
-            $audio += (int) $total;
-        } elseif ( 0 === strpos( $mime, 'video/' ) ) {
-            $video += (int) $total;
-        }
-    }
+    $has_audio = $wpdb->get_var( "
+        SELECT ID
+        FROM $wpdb->posts
+        WHERE post_type = 'attachment'
+        AND post_mime_type LIKE 'audio%'
+        LIMIT 1
+    " );
+    $has_video = $wpdb->get_var( "
+        SELECT ID
+        FROM $wpdb->posts
+        WHERE post_type = 'attachment'
+        AND post_mime_type LIKE 'video%'
+        LIMIT 1
+    " );
 
     $settings = array(
@@ -2718 +2723 @@
         'defaultProps' => $props,
         'attachmentCounts' => array(
-            'audio' => $audio,
-            'video' => $video
+            'audio' => (int) $has_audio,
+            'video' => (int) $has_video,
         ),
         'embedExts'    => $exts,