Changeset 28268 for trunk/src/wp-admin/includes/file.php

Timestamp:

05/06/2014 04:21:35 AM (11 years ago)

Author:

wonderboymusic

Message:

Dead code in wp-admin/includes/file.php:

• In wp_handle_upload() and wp_handle_sideload(), $ext gets conditionally reset... and then is never used.
• In request_filesystem_credentials(), $password is initialized as an empty string. The variable is never used.

See #27882.

File:

• trunk/src/wp-admin/includes/file.php (modified) (3 diffs)

trunk/src/wp-admin/includes/file.php

@@ -295 +295 @@
             return call_user_func($upload_error_handler, $file, __( 'Sorry, this file type is not permitted for security reasons.' ));
 
-        if ( !$ext )
-            $ext = ltrim(strrchr($file['name'], '.'), '.');
-
         if ( !$type )
             $type = $file['type'];
@@ -434 +431 @@
         if ( ( !$type || !$ext ) && !current_user_can( 'unfiltered_upload' ) )
             return $upload_error_handler( $file, __( 'Sorry, this file type is not permitted for security reasons.' ));
-
-        if ( !$ext )
-            $ext = ltrim(strrchr($file['name'], '.'), '.');
 
         if ( !$type )
@@ -1063 +1057 @@
     $hostname = '';
     $username = '';
-    $password = '';
     $connection_type = '';
     if ( !empty($credentials) )