Changeset 28292

Timestamp:

05/06/2014 03:18:42 PM (10 years ago)

Author:

wonderboymusic

Message:

In ajax-actions.php, remove dead code:

• In wp_ajax_add_tag(), $post_type is set and never used.
• In wp_ajax_hidden_columns(), $hidden is set twice, but only checks for the existence of $_POST['hidden'] the first time. The two lines can be combined and work together.
• In wp_ajax_inline_save(), $mode is set and never used.
• In wp_ajax_find_posts(), $searchand = $search = ''; is leftover cruft, neither variable is used. $wpdb does not need to be imported, it is never used.
• In wp_ajax_wp_fullscreen_save_post(), $post_type is set and never used.
• In wp_ajax_save_attachment_order(), $post is set and never used.
• In wp_ajax_send_attachment_to_editor(), $title is set and never used.

See #27882.

File:

• trunk/src/wp-admin/includes/ajax-actions.php (modified) (9 diffs)

trunk/src/wp-admin/includes/ajax-actions.php

@@ -639 +639 @@
 
     check_ajax_referer( 'add-tag', '_wpnonce_add-tag' );
-    $post_type = !empty($_POST['post_type']) ? $_POST['post_type'] : 'post';
     $taxonomy = !empty($_POST['taxonomy']) ? $_POST['taxonomy'] : 'post_tag';
     $tax = get_taxonomy($taxonomy);
@@ -879 +878 @@
 
     $position = ( isset($_POST['position']) && (int) $_POST['position']) ? (int) $_POST['position'] : '-1';
-    $comments_status = isset($_POST['comments_listing']) ? $_POST['comments_listing'] : '';
-
     $checkbox = ( isset($_POST['checkbox']) && true == $_POST['checkbox'] ) ? 1 : 0;
     $wp_list_table = _get_list_table( $checkbox ? 'WP_Comments_List_Table' : 'WP_Post_Comments_List_Table', array( 'screen' => 'edit-comments' ) );
@@ -1123 +1120 @@
 function wp_ajax_hidden_columns() {
     check_ajax_referer( 'screen-options-nonce', 'screenoptionnonce' );
-    $hidden = isset( $_POST['hidden'] ) ? $_POST['hidden'] : '';
-    $hidden = explode( ',', $_POST['hidden'] );
+    $hidden = explode( ',', isset( $_POST['hidden'] ) ? $_POST['hidden'] : '' );
     $page = isset( $_POST['page'] ) ? $_POST['page'] : '';
 
@@ -1333 +1329 @@
     $wp_list_table = _get_list_table( 'WP_Posts_List_Table', array( 'screen' => $_POST['screen'] ) );
 
-    $mode = $_POST['post_view'];
-
     $level = 0;
     $request_post = array( get_post( $_POST['post_ID'] ) );
@@ -1396 +1390 @@
 
 function wp_ajax_find_posts() {
-    global $wpdb;
-
     check_ajax_referer( 'find-posts' );
 
@@ -1404 +1396 @@
 
     $s = wp_unslash( $_POST['ps'] );
-    $searchand = $search = '';
     $args = array(
         'post_type' => array_keys( $post_types ),
@@ -1710 +1701 @@
     $post_id = isset( $_POST['post_ID'] ) ? (int) $_POST['post_ID'] : 0;
 
-    $post = $post_type = null;
+    $post = null;
 
     if ( $post_id )
         $post = get_post( $post_id );
-
-    if ( $post )
-        $post_type = $post->post_type;
-    elseif ( isset( $_POST['post_type'] ) && post_type_exists( $_POST['post_type'] ) )
-        $post_type = $_POST['post_type'];
 
     check_ajax_referer('update-post_' . $post_id, '_wpnonce');
@@ -1968 +1954 @@
         wp_send_json_error();
 
-    $post = get_post( $post_id, ARRAY_A );
-
     foreach ( $attachments as $attachment_id => $menu_order ) {
         if ( ! current_user_can( 'edit_post', $attachment_id ) )
@@ -2012 +1996 @@
 
     $rel = $url = '';
-    $html = $title = isset( $attachment['post_title'] ) ? $attachment['post_title'] : '';
+    $html = isset( $attachment['post_title'] ) ? $attachment['post_title'] : '';
     if ( ! empty( $attachment['url'] ) ) {
         $url = $attachment['url'];