Changeset 28304 for trunk/src/wp-admin/includes/update.php

Timestamp:

05/06/2014 05:20:10 PM (11 years ago)

Author:

wonderboymusic

Message:

In wp-admin/includes/update.php, remove dead code:

• In get_core_checksums(), $return is set and never used.
• In core_update_footer(), break is unnecessary and unreachable after return.
• In get_theme_updates(), $themes is set and never used.
• In wp_theme_update_row(), $theme_name is the only user of $themes_allowedtags... neither are used.

See #27882.

File:

• trunk/src/wp-admin/includes/update.php (modified) (4 diffs)

trunk/src/wp-admin/includes/update.php

@@ -102 +102 @@
  */
 function get_core_checksums( $version, $locale ) {
-    $return = array();
-
     $url = $http_url = 'http://api.wordpress.org/core/checksums/1.0/?' . http_build_query( compact( 'version', 'locale' ), null, '&' );
 
@@ -182 +180 @@
     case 'development' :
         return sprintf( __( 'You are using a development version (%1$s). Cool! Please <a href="%2$s">stay updated</a>.' ), get_bloginfo( 'version', 'display' ), network_admin_url( 'update-core.php' ) );
-    break;
 
     case 'upgrade' :
         return sprintf( '<strong>'.__( '<a href="%1$s">Get Version %2$s</a>' ).'</strong>', network_admin_url( 'update-core.php' ), $cur->current);
-    break;
 
     case 'latest' :
     default :
         return sprintf( __( 'Version %s' ), get_bloginfo( 'version', 'display' ) );
-    break;
     }
 }
@@ -333 +328 @@
 
 function get_theme_updates() {
-    $themes = wp_get_themes();
     $current = get_site_transient('update_themes');
 
@@ -368 +362 @@
         return false;
     $r = $current->response[ $theme_key ];
-    $themes_allowedtags = array('a' => array('href' => array(),'title' => array()),'abbr' => array('title' => array()),'acronym' => array('title' => array()),'code' => array(),'em' => array(),'strong' => array());
-    $theme_name = wp_kses( $theme['Name'], $themes_allowedtags );
 
     $details_url = add_query_arg( array( 'TB_iframe' => 'true', 'width' => 1024, 'height' => 800 ), $current->response[ $theme_key ]['url'] );