Changeset 28371

Timestamp:

05/11/2014 07:02:05 AM (10 years ago)

Author:

wonderboymusic

Message:

In wp.media.view.Settings::update(), when handling checkboxes, check for a value of 'false' in addition to casting value to boolean. !! 'false' evaluates to true.

Props adamsilverstein.
Fixes #23954.

File:

• trunk/src/wp-includes/js/media-views.js (modified) (1 diff)

trunk/src/wp-includes/js/media-views.js

@@ -5715 +5715 @@
             // Handle checkboxes.
             } else if ( $setting.is('input[type="checkbox"]') ) {
-                $setting.prop( 'checked', !! value );
+                $setting.prop( 'checked', !! value && 'false' !== value );
             }
         },