Changeset 28382

Timestamp:

05/13/2014 04:43:22 AM (12 years ago)

Author:

wonderboymusic

Message:

Eliminate use of extract() in trackback_url_list().

See #22400.

File:

• trunk/src/wp-includes/post.php (modified) (1 diff)

trunk/src/wp-includes/post.php

@@ -3821 +3821 @@
  * @param int $post_id Post ID
  */
-function trackback_url_list($tb_list, $post_id) {
+function trackback_url_list( $tb_list, $post_id ) {
         if ( ! empty( $tb_list ) ) {
                 // get post data
-                $postdata = get_post($post_id, ARRAY_A);
-
-                // import postdata as variables
-                extract($postdata, EXTR_SKIP);
+                $postdata = get_post( $post_id, ARRAY_A );
 
                 // form an excerpt
-                $excerpt = strip_tags($post_excerpt ? $post_excerpt : $post_content);
-
-                if (strlen($excerpt) > 255) {
-                        $excerpt = substr($excerpt,0,252) . '…';
+                $excerpt = strip_tags( $postdata['post_excerpt'] ? $postdata['post_excerpt'] : $postdata['post_content'] );
+
+                if ( strlen( $excerpt ) > 255 ) {
+                        $excerpt = substr( $excerpt, 0, 252 ) . '…';
                 }
 
-                $trackback_urls = explode(',', $tb_list);
-                foreach( (array) $trackback_urls as $tb_url) {
-                        $tb_url = trim($tb_url);
-                        trackback($tb_url, wp_unslash($post_title), $excerpt, $post_id);
+                $trackback_urls = explode( ',', $tb_list );
+                foreach( (array) $trackback_urls as $tb_url ) {
+                        $tb_url = trim( $tb_url );
+                        trackback( $tb_url, wp_unslash( $postdata['post_title'] ), $excerpt, $post_id );
                 }
         }