Changeset 28383

Timestamp:

05/13/2014 04:47:11 AM (9 years ago)

Author:

wonderboymusic

Message:

Eliminate use of extract() in the_title_attribute().

See #22400.

File:

• trunk/src/wp-includes/post-template.php (modified) (1 diff)

trunk/src/wp-includes/post-template.php

@@ -70 +70 @@
  */
 function the_title_attribute( $args = '' ) {
-    $defaults = array('before' => '', 'after' =>  '', 'echo' => true, 'post' => get_post() );
-    $r = wp_parse_args($args, $defaults);
-    extract( $r, EXTR_SKIP );
-
-    $title = get_the_title( $post );
-
-    if ( strlen($title) == 0 )
+    $defaults = array( 'before' => '', 'after' =>  '', 'echo' => true, 'post' => get_post() );
+    $r = wp_parse_args( $args, $defaults );
+
+    $title = get_the_title( $r['post'] );
+
+    if ( strlen( $title ) == 0 ) {
         return;
-
-    $title = $before . $title . $after;
-    $title = esc_attr(strip_tags($title));
-
-    if ( $echo )
+    }
+
+    $title = $r['before'] . $title . $r['after'];
+    $title = esc_attr( strip_tags( $title ) );
+
+    if ( $r['echo'] ) {
         echo $title;
-    else
+    } else {
         return $title;
+    }
 }