Changeset 28385 for trunk/src/wp-admin/includes/class-wp-comments-list-table.php

Timestamp:

05/13/2014 05:03:26 AM (11 years ago)

Author:

wonderboymusic

Message:

Eliminate use of extract() in WP_Post_Comments_List_Table::display(). The method only needs to read singular from $this->_args. Extraction is unnecessary.

Eliminate use of extract() in WP_Comments_List_Table::display(). The method uses no variables. Extraction can be completely removed.

See #22400.

File:

• trunk/src/wp-admin/includes/class-wp-comments-list-table.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-comments-list-table.php

@@ -310 +310 @@
 
     function display() {
-        extract( $this->_args );
-
         wp_nonce_field( "fetch-list-" . get_class( $this ), '_ajax_fetch_list_nonce' );
 
@@ -599 +597 @@
 
     function display( $output_empty = false ) {
-        extract( $this->_args );
+        $singular = $this->_args['singular'];
 
         wp_nonce_field( "fetch-list-" . get_class( $this ), '_ajax_fetch_list_nonce' );
 ?>
 <table class="<?php echo implode( ' ', $this->get_table_classes() ); ?>" style="display:none;">
-    <tbody id="the-comment-list"<?php if ( $singular ) echo " data-wp-lists='list:$singular'"; ?>>
-        <?php if ( ! $output_empty ) $this->display_rows_or_placeholder(); ?>
+    <tbody id="the-comment-list"<?php
+        if ( $singular ) {
+            echo " data-wp-lists='list:$singular'";
+        } ?>>
+        <?php if ( ! $output_empty ) {
+            $this->display_rows_or_placeholder();
+        } ?>
     </tbody>
 </table>