Changeset 28386

Timestamp:

05/13/2014 05:07:11 AM (12 years ago)

Author:

wonderboymusic

Message:

Eliminate use of extract() in WP_List_Table::display(). The method only needs to read singular from $this->_args. Extraction is unnecessary.

See #22400.

File:

• trunk/src/wp-admin/includes/class-wp-list-table.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-list-table.php

@@ -761 +761 @@
          */
         function display() {
-                extract( $this->_args );
+                $singular = $this->_args['singular'];
 
                 $this->display_tablenav( 'top' );
@@ -779 +779 @@
         </tfoot>
 
-        <tbody id="the-list"<?php if ( $singular ) echo " data-wp-lists='list:$singular'"; ?>>
+        <tbody id="the-list"<?php
+                if ( $singular ) {
+                        echo " data-wp-lists='list:$singular'";
+                } ?>>
                 <?php $this->display_rows_or_placeholder(); ?>
         </tbody>