WordPress.org

Make WordPress Core

Changeset 28386


Ignore:
Timestamp:
05/13/2014 05:07:11 AM (7 years ago)
Author:
wonderboymusic
Message:

Eliminate use of extract() in WP_List_Table::display(). The method only needs to read singular from $this->_args. Extraction is unnecessary.

See #22400.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/includes/class-wp-list-table.php

    r28279 r28386  
    761761     */
    762762    function display() {
    763         extract( $this->_args );
     763        $singular = $this->_args['singular'];
    764764
    765765        $this->display_tablenav( 'top' );
     
    779779    </tfoot>
    780780
    781     <tbody id="the-list"<?php if ( $singular ) echo " data-wp-lists='list:$singular'"; ?>>
     781    <tbody id="the-list"<?php
     782        if ( $singular ) {
     783            echo " data-wp-lists='list:$singular'";
     784        } ?>>
    782785        <?php $this->display_rows_or_placeholder(); ?>
    783786    </tbody>
Note: See TracChangeset for help on using the changeset viewer.