Changeset 28387

Timestamp:

05/13/2014 05:13:09 AM (12 years ago)

Author:

wonderboymusic

Message:

Eliminate use of extract() in WP_List_Table::ajax_response():

• Extracting $this->_args is unnecessary since none of the variables produced are present in the method.
• total_items and total_pages can be read directly from $this->_pagination_args

See #22400.

File:

• trunk/src/wp-admin/includes/class-wp-list-table.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-list-table.php

@@ -926 +926 @@
                 $this->prepare_items();
 
-                extract( $this->_args );
-                extract( $this->_pagination_args, EXTR_SKIP );
-
                 ob_start();
-                if ( ! empty( $_REQUEST['no_placeholder'] ) )
+                if ( ! empty( $_REQUEST['no_placeholder'] ) ) {
                         $this->display_rows();
-                else
+                } else {
                         $this->display_rows_or_placeholder();
+                }
 
                 $rows = ob_get_clean();
@@ -939 +937 @@
                 $response = array( 'rows' => $rows );
 
-                if ( isset( $total_items ) )
-                        $response['total_items_i18n'] = sprintf( _n( '1 item', '%s items', $total_items ), number_format_i18n( $total_items ) );
-
-                if ( isset( $total_pages ) ) {
-                        $response['total_pages'] = $total_pages;
-                        $response['total_pages_i18n'] = number_format_i18n( $total_pages );
+                if ( isset( $this->_pagination_args['total_items'] ) ) {
+                        $response['total_items_i18n'] = sprintf(
+                                _n( '1 item', '%s items', $this->_pagination_args['total_items'] ),
+                                number_format_i18n( $this->_pagination_args['total_items'] )
+                        );
+                }
+                if ( isset( $this->_pagination_args['total_pages'] ) ) {
+                        $response['total_pages'] = $this->_pagination_args['total_pages'];
+                        $response['total_pages_i18n'] = number_format_i18n( $this->_pagination_args['total_pages'] );
                 }