Changeset 28409

Timestamp:

05/15/2014 02:56:56 AM (12 years ago)

Author:

wonderboymusic

Message:

Eliminate use of extract() in wp_star_rating().

See #22400.

File:

• trunk/src/wp-admin/includes/template.php (modified) (2 diffs)

trunk/src/wp-admin/includes/template.php

@@ -2071 +2071 @@
         );
         $r = wp_parse_args( $args, $defaults );
-        extract( $r, EXTR_SKIP );
 
         // Non-english decimal places when the $rating is coming from a string
-        $rating = str_replace( ',', '.', $rating );
+        $rating = str_replace( ',', '.', $r['rating'] );
 
         // Convert Percentage to star rating, 0..5 in .5 increments
-        if ( 'percent' == $type ) {
+        if ( 'percent' == $r['type'] ) {
                 $rating = round( $rating / 10, 0 ) / 2;
         }
@@ -2086 +2085 @@
         $empty_stars = 5 - $full_stars - $half_stars;
 
-        if ( $number ) {
+        if ( $r['number'] ) {
                 /* translators: 1: The rating, 2: The number of ratings */
-                $title = _n( '%1$s rating based on %2$s rating', '%1$s rating based on %2$s ratings', $number );
-                $title = sprintf( $title, number_format_i18n( $rating, 1 ), number_format_i18n( $number ) );
+                $format = _n( '%1$s rating based on %2$s rating', '%1$s rating based on %2$s ratings', $r['number'] );
+                $title = sprintf( $format, number_format_i18n( $rating, 1 ), number_format_i18n( $r['number'] ) );
         } else {
                 /* translators: 1: The rating */