Changeset 28421

Timestamp:

05/15/2014 05:24:54 AM (10 years ago)

Author:

wonderboymusic

Message:

Eliminate the use of extract() in the_taxonomies(). Adds unit test.

See #22400.

Location:

trunk

Files:

• src/wp-includes/taxonomy.php (modified) (2 diffs)
• tests/phpunit/tests/taxonomy.php (modified) (1 diff)

trunk/src/wp-includes/taxonomy.php

@@ -3686 +3686 @@
  * @param array $args Override the defaults.
  */
-function the_taxonomies($args = array()) {
+function the_taxonomies( $args = array() ) {
     $defaults = array(
         'post' => 0,
@@ -3696 +3696 @@
 
     $r = wp_parse_args( $args, $defaults );
-    extract( $r, EXTR_SKIP );
-
-    echo $before . join($sep, get_the_taxonomies($post, $r)) . $after;
+
+    echo $r['before'] . join( $r['sep'], get_the_taxonomies( $r['post'], $r ) ) . $r['after'];
 }
 

trunk/tests/phpunit/tests/taxonomy.php

@@ -50 +50 @@
     }
 
+    function test_the_taxonomies() {
+        $post_id = $this->factory->post->create();
+
+        ob_start();
+        the_taxonomies( array( 'post' => $post_id ) );
+        $output = ob_get_clean();
+
+        $link = get_category_link( 1 );
+        $expected = "Categories: <a href='$link'>Uncategorized</a>.";
+        $this->assertEquals( $expected, $output );
+    }
+
     function test_get_link_taxonomy() {
         foreach ( get_object_taxonomies('link') as $taxonomy ) {