Changeset 28424

Timestamp:

05/15/2014 06:10:21 AM (12 years ago)

Author:

wonderboymusic

Message:

Eliminate the use of extract() in wp_validate_auth_cookie().

Don't do anything fancy here, just set the 4 returned properties to variables. This function is semi-important.

See #22400.

File:

• trunk/src/wp-includes/pluggable.php (modified) (2 diffs)

trunk/src/wp-includes/pluggable.php

@@ -609 +609 @@
         }
 
-        extract($cookie_elements, EXTR_OVERWRITE);
-
-        $expired = $expiration;
+        $scheme = $cookie_elements['scheme'];
+        $username = $cookie_elements['username'];
+        $hmac = $cookie_elements['hmac'];
+        $expired = $expiration = $cookie_elements['expiration'];
 
         // Allow a grace period for POST and AJAX requests
-        if ( defined('DOING_AJAX') || 'POST' == $_SERVER['REQUEST_METHOD'] )
+        if ( defined('DOING_AJAX') || 'POST' == $_SERVER['REQUEST_METHOD'] ) {
                 $expired += HOUR_IN_SECONDS;
+        }
 
         // Quick check to see if an honest cookie has expired
@@ -660 +662 @@
         }
 
-        if ( $expiration < time() ) // AJAX/POST grace period set above
+        if ( $expiration < time() ) {// AJAX/POST grace period set above
                 $GLOBALS['login_grace_period'] = 1;
+        }
 
         /**