Changeset 28439 for trunk/src/wp-includes/default-widgets.php

Timestamp:

05/15/2014 07:35:31 PM (12 years ago)

Author:

wonderboymusic

Message:

Eliminate use of extract() in WP_Widget_RSS::widget().

See #22400.

File:

• trunk/src/wp-includes/default-widgets.php (modified) (2 diffs)

trunk/src/wp-includes/default-widgets.php

@@ -930 +930 @@
                         return;
 
-                extract($args, EXTR_SKIP);
-
                 $url = ! empty( $instance['url'] ) ? $instance['url'] : '';
                 while ( stristr($url, 'http') != $url )
@@ -968 +966 @@
                         $title = "<a class='rsswidget' href='$url' title='" . esc_attr__( 'Syndicate this content' ) ."'><img style='border:0' width='14' height='14' src='$icon' alt='RSS' /></a> <a class='rsswidget' href='$link' title='$desc'>$title</a>";
 
-                echo $before_widget;
-                if ( $title )
-                        echo $before_title . $title . $after_title;
+                echo $args['before_widget'];
+                if ( $title ) {
+                        echo $args['before_title'] . $title . $args['after_title'];
+                }
                 wp_widget_rss_output( $rss, $instance );
-                echo $after_widget;
+                echo $args['after_widget'];
 
                 if ( ! is_wp_error($rss) )