Changeset 28440

Timestamp:

05/15/2014 07:41:41 PM (9 years ago)

Author:

wonderboymusic

Message:

Eliminate use of extract() in wp_widget_rss_output().

Add 'items' => 0 to $default_args. When 0, the value is set to 10 (the fallback).
Every other default arg has a default value of 0.

items is expected to always be passed to this function.

See #22400.

File:

• trunk/src/wp-includes/default-widgets.php (modified) (1 diff)

trunk/src/wp-includes/default-widgets.php

@@ -1017 +1017 @@
     }
 
-    $default_args = array( 'show_author' => 0, 'show_date' => 0, 'show_summary' => 0 );
+    $default_args = array( 'show_author' => 0, 'show_date' => 0, 'show_summary' => 0, 'items' => 0 );
     $args = wp_parse_args( $args, $default_args );
-    extract( $args, EXTR_SKIP );
-
-    $items = (int) $items;
+
+    $items = (int) $args['items'];
     if ( $items < 1 || 20 < $items )
         $items = 10;
-    $show_summary  = (int) $show_summary;
-    $show_author   = (int) $show_author;
-    $show_date     = (int) $show_date;
+    $show_summary  = (int) $args['show_summary'];
+    $show_author   = (int) $args['show_author'];
+    $show_date     = (int) $args['show_date'];
 
     if ( !$rss->get_item_quantity() ) {