Changeset 28445

Timestamp:

05/16/2014 02:42:25 PM (10 years ago)

Author:

wonderboymusic

Message:

Eliminate use of extract() in validate_another_blog_signup().

The extracted variables set/overwrite globals. $user does not need to be pulled from validate_blog_form() as it is not used in this function.

See #22400.

File:

• trunk/src/wp-signup.php (modified) (3 diffs)

trunk/src/wp-signup.php

@@ -316 +316 @@
 
     $result = validate_blog_form();
-    extract($result);
+
+    // extracted values set/overwrite globals
+    $domain = $result['domain'];
+    $path = $result['path'];
+    $blogname = $result['blogname'];
+    $blog_title = $result['blog_title'];
+    $errors = $result['errors'];
 
     if ( $errors->get_error_code() ) {
@@ -338 +344 @@
      * @param array $blog_meta_defaults An array of default blog meta variables.
      */
-    $meta = apply_filters( 'signup_create_blog_meta', $blog_meta_defaults );
+    $meta_defaults = apply_filters( 'signup_create_blog_meta', $blog_meta_defaults );
     /**
      * Filter the new default site meta variables.
@@ -351 +357 @@
      * }
      */
-    $meta = apply_filters( 'add_signup_meta', $meta );
+    $meta = apply_filters( 'add_signup_meta', $meta_defaults );
 
     wpmu_create_blog( $domain, $path, $blog_title, $current_user->ID, $meta, $wpdb->siteid );