Changeset 28448

Timestamp:

05/16/2014 03:18:17 PM (11 years ago)

Author:

wonderboymusic

Message:

Eliminate use of extract() in wp_xmlrpc_server::mw_editPost() (MetaWeblog API, y'all).

A lot of the extracted variables are overwritten by being explicitly set later.
Only set variables that would otherwise not be present with compact() is called.

See #22400.

File:

• trunk/src/wp-includes/class-wp-xmlrpc-server.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-xmlrpc-server.php

@@ -4728 +4728 @@
 
         $this->escape($postdata);
-        extract($postdata, EXTR_SKIP);
+
+        $ID = $postdata['ID'];
+        $post_content = $postdata['post_content'];
+        $post_title = $postdata['post_title'];
+        $post_excerpt = $postdata['post_excerpt'];
+        $post_password = $postdata['post_password'];
+        $post_parent = $postdata['post_parent'];
+        $menu_order = $postdata['menu_order'];
 
         // Let WordPress manage slug if none was provided.
@@ -4748 +4755 @@
             $menu_order = $content_struct['wp_page_order'];
 
+        $page_template = null;
         if ( ! empty( $content_struct['wp_page_template'] ) && 'page' == $post_type )
             $page_template = $content_struct['wp_page_template'];