Changeset 28481 for trunk/src/wp-admin/custom-background.php

Timestamp:

05/18/2014 09:30:43 PM (11 years ago)

Author:

wonderboymusic

Message:

Use proper access modifiers and add a magic __get() method to Custom_Background and Custom_Image_Header.

See #27881, #22234.

File:

• trunk/src/wp-admin/custom-background.php (modified) (11 diffs)

trunk/src/wp-admin/custom-background.php

@@ -23 +23 @@
      * @access private
      */
-    var $admin_header_callback;
+    private $admin_header_callback;
 
     /**
@@ -32 +32 @@
      * @access private
      */
-    var $admin_image_div_callback;
+    private $admin_image_div_callback;
 
     /**
@@ -41 +41 @@
      * @access private
      */
-    var $page = '';
+    private $page = '';
 
     /**
@@ -51 +51 @@
      * @return Custom_Background
      */
-    function __construct($admin_header_callback = '', $admin_image_div_callback = '') {
+    public function __construct($admin_header_callback = '', $admin_image_div_callback = '') {
         $this->admin_header_callback = $admin_header_callback;
         $this->admin_image_div_callback = $admin_image_div_callback;
@@ -60 +60 @@
 
     /**
+     * Make private properties readable for backwards compatibility
+     *
+     * @since 4.0.0
+     * @param string $name
+     * @return mixed
+     */
+    public function __get( $name ) {
+        return $this->$name;
+    }
+
+    /**
      * Set up the hooks for the Custom Background admin page.
      *
      * @since 3.0.0
      */
-    function init() {
+    public function init() {
         if ( ! current_user_can('edit_theme_options') )
             return;
@@ -83 +94 @@
      * @since 3.0.0
      */
-    function admin_load() {
+    public function admin_load() {
         get_current_screen()->add_help_tab( array(
             'id'      => 'overview',
@@ -110 +121 @@
      * @since 3.0.0
      */
-    function take_action() {
+    public function take_action() {
 
         if ( empty($_POST) )
@@ -177 +188 @@
      * @since 3.0.0
      */
-    function admin_page() {
+    public function admin_page() {
 ?>
 <div class="wrap" id="custom-background">
@@ -344 +355 @@
      * @since 3.0.0
      */
-    function handle_upload() {
+    public function handle_upload() {
 
         if ( empty($_FILES) )
@@ -398 +409 @@
      * @since 3.4.0
      */
-    function attachment_fields_to_edit( $form_fields ) {
+    public function attachment_fields_to_edit( $form_fields ) {
         return $form_fields;
     }
@@ -407 +418 @@
      * @since 3.4.0
      */
-    function filter_upload_tabs( $tabs ) {
+    public function filter_upload_tabs( $tabs ) {
         return $tabs;
     }