Changeset 28493 for trunk/src/wp-admin/includes/class-wp-media-list-table.php

Timestamp:

05/19/2014 01:16:16 AM (11 years ago)

Author:

wonderboymusic

Message:

Add access modifiers to methods and members of list table classes:

• WP_List_Table is the base class that implements __get() and __call() for BC
• Adds unit tests to confirm that subclasses properly inherit magic methods
• Add modifiers to subclasses: WP_Links_List_Table, WP_Media_List_Table, WP_MS_Sites_List_Table, WP_MS_Themes_List_Table, WP_MS_Users_List_Table, WP_Plugin_Install_List_Table, WP_Plugins_List_Table, WP_Posts_List_Table, WP_Terms_List_Table, WP_Theme_Install_List_Table, WP_Themes_List_Table

See #27881, #22234.

File:

• trunk/src/wp-admin/includes/class-wp-media-list-table.php (modified) (10 diffs)

trunk/src/wp-admin/includes/class-wp-media-list-table.php

@@ -10 +10 @@
 class WP_Media_List_Table extends WP_List_Table {
 
-    function __construct( $args = array() ) {
+    public function __construct( $args = array() ) {
         $this->detached = isset( $_REQUEST['detached'] ) || isset( $_REQUEST['find_detached'] );
 
@@ -19 +19 @@
     }
 
-    function ajax_user_can() {
+    public function ajax_user_can() {
         return current_user_can('upload_files');
     }
 
-    function prepare_items() {
+    public function prepare_items() {
         global $lost, $wp_query, $post_mime_types, $avail_post_mime_types;
 
@@ -42 +42 @@
     }
 
-    function get_views() {
+    protected function get_views() {
         global $wpdb, $post_mime_types, $avail_post_mime_types;
 
@@ -75 +75 @@
     }
 
-    function get_bulk_actions() {
+    protected function get_bulk_actions() {
         $actions = array();
         $actions['delete'] = __( 'Delete Permanently' );
@@ -84 +84 @@
     }
 
-    function extra_tablenav( $which ) {
+    protected function extra_tablenav( $which ) {
 ?>
         <div class="alignleft actions">
@@ -105 +105 @@
     }
 
-    function current_action() {
+    public function current_action() {
         if ( isset( $_REQUEST['find_detached'] ) )
             return 'find_detached';
@@ -118 +118 @@
     }
 
-    function has_items() {
+    public function has_items() {
         return have_posts();
     }
 
-    function no_items() {
+    public function no_items() {
         _e( 'No media attachments found.' );
     }
 
-    function get_columns() {
+    protected function get_columns() {
         $posts_columns = array();
         $posts_columns['cb'] = '<input type="checkbox" />';
@@ -181 +181 @@
     }
 
-    function get_sortable_columns() {
+    protected function get_sortable_columns() {
         return array(
             'title'    => 'title',
@@ -191 +191 @@
     }
 
-    function display_rows() {
+    protected function display_rows() {
         global $post;
 
@@ -422 +422 @@
     }
 
-    function _get_row_actions( $post, $att_title ) {
+    private function _get_row_actions( $post, $att_title ) {
         $actions = array();