Changeset 28493 for trunk/src/wp-admin/includes/class-wp-posts-list-table.php

Timestamp:

05/19/2014 01:16:16 AM (12 years ago)

Author:

wonderboymusic

Message:

Add access modifiers to methods and members of list table classes:

• WP_List_Table is the base class that implements __get() and __call() for BC
• Adds unit tests to confirm that subclasses properly inherit magic methods
• Add modifiers to subclasses: WP_Links_List_Table, WP_Media_List_Table, WP_MS_Sites_List_Table, WP_MS_Themes_List_Table, WP_MS_Users_List_Table, WP_Plugin_Install_List_Table, WP_Plugins_List_Table, WP_Posts_List_Table, WP_Terms_List_Table, WP_Theme_Install_List_Table, WP_Themes_List_Table

See #27881, #22234.

File:

• trunk/src/wp-admin/includes/class-wp-posts-list-table.php (modified) (19 diffs)

trunk/src/wp-admin/includes/class-wp-posts-list-table.php

@@ -17 +17 @@
          * @access protected
          */
-        var $hierarchical_display;
+        protected $hierarchical_display;
 
         /**
@@ -26 +26 @@
          * @access protected
          */
-        var $comment_pending_count;
+        protected $comment_pending_count;
 
         /**
@@ -35 +35 @@
          * @access private
          */
-        var $user_posts_count;
+        private $user_posts_count;
 
         /**
@@ -44 +44 @@
          * @access private
          */
-        var $sticky_posts_count = 0;
-
-        function __construct( $args = array() ) {
+        private $sticky_posts_count = 0;
+
+        public function __construct( $args = array() ) {
                 global $post_type_object, $wpdb;
 
@@ -75 +75 @@
         }
 
-        function ajax_user_can() {
+        public function ajax_user_can() {
                 return current_user_can( get_post_type_object( $this->screen->post_type )->cap->edit_posts );
         }
 
-        function prepare_items() {
+        public function prepare_items() {
                 global $avail_post_stati, $wp_query, $per_page, $mode;
 
@@ -110 +110 @@
         }
 
-        function has_items() {
+        public function has_items() {
                 return have_posts();
         }
 
-        function no_items() {
+        public function no_items() {
                 if ( isset( $_REQUEST['post_status'] ) && 'trash' == $_REQUEST['post_status'] )
                         echo get_post_type_object( $this->screen->post_type )->labels->not_found_in_trash;
@@ -121 +121 @@
         }
 
-        function get_views() {
+        protected function get_views() {
                 global $locked_post_status, $avail_post_stati;
 
@@ -182 +182 @@
         }
 
-        function get_bulk_actions() {
+        protected function get_bulk_actions() {
                 $actions = array();
 
@@ -198 +198 @@
         }
 
-        function extra_tablenav( $which ) {
+        protected function extra_tablenav( $which ) {
                 global $cat;
 ?>
@@ -240 +240 @@
         }
 
-        function current_action() {
+        public function current_action() {
                 if ( isset( $_REQUEST['delete_all'] ) || isset( $_REQUEST['delete_all2'] ) )
                         return 'delete_all';
@@ -247 +247 @@
         }
 
-        function pagination( $which ) {
+        protected function pagination( $which ) {
                 global $mode;
 
@@ -256 +256 @@
         }
 
-        function get_table_classes() {
+        protected function get_table_classes() {
                 return array( 'widefat', 'fixed', is_post_type_hierarchical( $this->screen->post_type ) ? 'pages' : 'posts' );
         }
 
-        function get_columns() {
+        protected function get_columns() {
                 $post_type = $this->screen->post_type;
 
@@ -346 +346 @@
         }
 
-        function get_sortable_columns() {
+        protected function get_sortable_columns() {
                 return array(
                         'title'    => 'title',
@@ -355 +355 @@
         }
 
-        function display_rows( $posts = array(), $level = 0 ) {
+        protected function display_rows( $posts = array(), $level = 0 ) {
                 global $wp_query, $per_page;
 
@@ -370 +370 @@
         }
 
-        function _display_rows( $posts, $level = 0 ) {
+        private function _display_rows( $posts, $level = 0 ) {
                 global $mode;
 
@@ -385 +385 @@
         }
 
-        function _display_rows_hierarchical( $pages, $pagenum = 1, $per_page = 20 ) {
+        private function _display_rows_hierarchical( $pages, $pagenum = 1, $per_page = 20 ) {
                 global $wpdb;
 
@@ -477 +477 @@
          * @param int $per_page
          */
-        function _page_rows( &$children_pages, &$count, $parent, $level, $pagenum, $per_page ) {
+        private function _page_rows( &$children_pages, &$count, $parent, $level, $pagenum, $per_page ) {
 
                 if ( ! isset( $children_pages[$parent] ) )
@@ -522 +522 @@
         }
 
-        function single_row( $post, $level = 0 ) {
+        protected function single_row( $post, $level = 0 ) {
                 global $mode;
                 static $alternate;
@@ -880 +880 @@
          * @since 3.1.0
          */
-        function inline_edit() {
+        public function inline_edit() {
                 global $mode;