Changeset 28493 for trunk/src/wp-admin/includes/class-wp-theme-install-list-table.php

Timestamp:

05/19/2014 01:16:16 AM (11 years ago)

Author:

wonderboymusic

Message:

Add access modifiers to methods and members of list table classes:

• WP_List_Table is the base class that implements __get() and __call() for BC
• Adds unit tests to confirm that subclasses properly inherit magic methods
• Add modifiers to subclasses: WP_Links_List_Table, WP_Media_List_Table, WP_MS_Sites_List_Table, WP_MS_Themes_List_Table, WP_MS_Users_List_Table, WP_Plugin_Install_List_Table, WP_Plugins_List_Table, WP_Posts_List_Table, WP_Terms_List_Table, WP_Theme_Install_List_Table, WP_Themes_List_Table

See #27881, #22234.

File:

• trunk/src/wp-admin/includes/class-wp-theme-install-list-table.php (modified) (9 diffs)

trunk/src/wp-admin/includes/class-wp-theme-install-list-table.php

@@ -10 +10 @@
 class WP_Theme_Install_List_Table extends WP_Themes_List_Table {
 
-    var $features = array();
-
-    function ajax_user_can() {
+    public $features = array();
+
+    public function ajax_user_can() {
         return current_user_can( 'install_themes' );
     }
 
-    function prepare_items() {
+    public function prepare_items() {
         include( ABSPATH . 'wp-admin/includes/theme-install.php' );
 
@@ -141 +141 @@
     }
 
-    function no_items() {
+    public function no_items() {
         _e( 'No themes match your request.' );
     }
 
-    function get_views() {
+    protected function get_views() {
         global $tabs, $tab;
 
@@ -158 +158 @@
     }
 
-    function display() {
+    public function display() {
         wp_nonce_field( "fetch-list-" . get_class( $this ), '_ajax_fetch_list_nonce' );
 ?>
@@ -184 +184 @@
     }
 
-    function display_rows() {
+    protected function display_rows() {
         $themes = $this->items;
         foreach ( $themes as $theme ) {
@@ -215 +215 @@
      *     public 'download_link' => string 'http://wordpress.org/themes/download/magazine-basic.1.1.zip'
      */
-    function single_row( $theme ) {
+    protected function single_row( $theme ) {
         global $themes_allowedtags;
 
@@ -295 +295 @@
      * Prints the wrapper for the theme installer.
      */
-    function theme_installer() {
+    public function theme_installer() {
         ?>
         <div id="theme-installer" class="wp-full-overlay expanded">
@@ -324 +324 @@
      * @param object $theme - A WordPress.org Theme API object.
      */
-    function theme_installer_single( $theme ) {
+    public function theme_installer_single( $theme ) {
         ?>
         <div id="theme-installer" class="wp-full-overlay single-theme">
@@ -342 +342 @@
      * @param object $theme - A WordPress.org Theme API object.
      */
-    function install_theme_info( $theme ) {
+    public function install_theme_info( $theme ) {
         global $themes_allowedtags;
 
@@ -409 +409 @@
      * @uses $type Global; type of search.
      */
-    function _js_vars( $extra_args = array() ) {
+    private function _js_vars( $extra_args = array() ) {
         global $tab, $type;
         parent::_js_vars( compact( 'tab', 'type' ) );