Changeset 28500 for trunk/src/wp-admin/includes/nav-menu.php

Timestamp:

05/19/2014 05:03:44 AM (11 years ago)

Author:

wonderboymusic

Message:

Fix some hackificator odds and ends in wp-admin:

• wp-activate.php and wp-admin/themes.php don't need the closing PHP tag
• Switch single quotes for HTML attribute values to double in a few places
• Convert include_once file.php syntax to include_once( 'file.php' )
• Add access modifiers to methods/members in: _WP_List_Table_Compat, Walker_Nav_Menu_Edit, Walker_Nav_Menu_Checklist, WP_Screen, Walker_Category_Checklist
• edit_user() doesn't need to import the $wpdb global
• wp_list_widgets() doesn't need to import the $sidebars_widgets global
• switch/endswitch syntax is not supported in Hack
• A <ul> in wp-admin/users.php is unclosed

See #27881.

File:

• trunk/src/wp-admin/includes/nav-menu.php (modified) (7 diffs)

trunk/src/wp-admin/includes/nav-menu.php

@@ -20 +20 @@
      * @param array  $args   Not used.
      */
-    function start_lvl( &$output, $depth = 0, $args = array() ) {}
+    public function start_lvl( &$output, $depth = 0, $args = array() ) {}
 
     /**
@@ -33 +33 @@
      * @param array  $args   Not used.
      */
-    function end_lvl( &$output, $depth = 0, $args = array() ) {}
+    public function end_lvl( &$output, $depth = 0, $args = array() ) {}
 
     /**
@@ -47 +47 @@
      * @param int    $id     Not used.
      */
-    function start_el( &$output, $item, $depth = 0, $args = array(), $id = 0 ) {
+    public function start_el( &$output, $item, $depth = 0, $args = array(), $id = 0 ) {
         global $_wp_nav_menu_max_depth;
         $_wp_nav_menu_max_depth = $depth > $_wp_nav_menu_max_depth ? $depth : $_wp_nav_menu_max_depth;
@@ -236 +236 @@
  */
 class Walker_Nav_Menu_Checklist extends Walker_Nav_Menu {
-    function __construct( $fields = false ) {
+    public function __construct( $fields = false ) {
         if ( $fields ) {
             $this->db_fields = $fields;
@@ -253 +253 @@
      * @param array  $args   Not used.
      */
-    function start_lvl( &$output, $depth = 0, $args = array() ) {
+    public function start_lvl( &$output, $depth = 0, $args = array() ) {
         $indent = str_repeat( "\t", $depth );
         $output .= "\n$indent<ul class='children'>\n";
@@ -269 +269 @@
      * @param array  $args   Not used.
      */
-    function end_lvl( &$output, $depth = 0, $args = array() ) {
+    public function end_lvl( &$output, $depth = 0, $args = array() ) {
         $indent = str_repeat( "\t", $depth );
         $output .= "\n$indent</ul>";
@@ -287 +287 @@
      * @param int    $id     Not used.
      */
-    function start_el( &$output, $item, $depth = 0, $args = array(), $id = 0 ) {
+    public function start_el( &$output, $item, $depth = 0, $args = array(), $id = 0 ) {
         global $_nav_menu_placeholder;