WordPress.org

Make WordPress Core


Ignore:
Timestamp:
05/19/2014 05:03:44 AM (8 years ago)
Author:
wonderboymusic
Message:

Fix some hackificator odds and ends in wp-admin:

  • wp-activate.php and wp-admin/themes.php don't need the closing PHP tag
  • Switch single quotes for HTML attribute values to double in a few places
  • Convert include_once file.php syntax to include_once( 'file.php' )
  • Add access modifiers to methods/members in: _WP_List_Table_Compat, Walker_Nav_Menu_Edit, Walker_Nav_Menu_Checklist, WP_Screen, Walker_Category_Checklist
  • edit_user() doesn't need to import the $wpdb global
  • wp_list_widgets() doesn't need to import the $sidebars_widgets global
  • switch/endswitch syntax is not supported in Hack
  • A <ul> in wp-admin/users.php is unclosed

See #27881.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/includes/taxonomy.php

    r28474 r28500  
    237237    $tags = wp_get_post_terms($post_id, $taxonomy, array());
    238238
    239     if ( !$tags )
     239    if ( !$tags ) {
    240240        return false;
    241 
    242     if ( is_wp_error($tags) )
     241    }
     242    if ( is_wp_error($tags) ) {
    243243        return $tags;
    244 
    245     foreach ( $tags as $tag )
     244    }
     245    $tag_names = array();
     246    foreach ( $tags as $tag ) {
    246247        $tag_names[] = $tag->name;
    247     $tags_to_edit = join( ',', $tag_names );
    248     $tags_to_edit = esc_attr( $tags_to_edit );
     248    }
     249
     250    $tags_to_edit = esc_attr( join( ',', $tag_names ) );
    249251
    250252    /**
Note: See TracChangeset for help on using the changeset viewer.