Changeset 28500 for trunk/src/wp-admin/includes/taxonomy.php

Timestamp:

05/19/2014 05:03:44 AM (11 years ago)

Author:

wonderboymusic

Message:

Fix some hackificator odds and ends in wp-admin:

• wp-activate.php and wp-admin/themes.php don't need the closing PHP tag
• Switch single quotes for HTML attribute values to double in a few places
• Convert include_once file.php syntax to include_once( 'file.php' )
• Add access modifiers to methods/members in: _WP_List_Table_Compat, Walker_Nav_Menu_Edit, Walker_Nav_Menu_Checklist, WP_Screen, Walker_Category_Checklist
• edit_user() doesn't need to import the $wpdb global
• wp_list_widgets() doesn't need to import the $sidebars_widgets global
• switch/endswitch syntax is not supported in Hack
• A <ul> in wp-admin/users.php is unclosed

See #27881.

File:

• trunk/src/wp-admin/includes/taxonomy.php (modified) (1 diff)

trunk/src/wp-admin/includes/taxonomy.php

@@ -237 +237 @@
     $tags = wp_get_post_terms($post_id, $taxonomy, array());
 
-    if ( !$tags )
+    if ( !$tags ) {
         return false;
-
-    if ( is_wp_error($tags) )
+    }
+    if ( is_wp_error($tags) ) {
         return $tags;
-
-    foreach ( $tags as $tag )
+    }
+    $tag_names = array();
+    foreach ( $tags as $tag ) {
         $tag_names[] = $tag->name;
-    $tags_to_edit = join( ',', $tag_names );
-    $tags_to_edit = esc_attr( $tags_to_edit );
+    }
+
+    $tags_to_edit = esc_attr( join( ',', $tag_names ) );
 
     /**