Changeset 28500 for trunk/src/wp-admin/update-core.php

Timestamp:

05/19/2014 05:03:44 AM (11 years ago)

Author:

wonderboymusic

Message:

Fix some hackificator odds and ends in wp-admin:

• wp-activate.php and wp-admin/themes.php don't need the closing PHP tag
• Switch single quotes for HTML attribute values to double in a few places
• Convert include_once file.php syntax to include_once( 'file.php' )
• Add access modifiers to methods/members in: _WP_List_Table_Compat, Walker_Nav_Menu_Edit, Walker_Nav_Menu_Checklist, WP_Screen, Walker_Category_Checklist
• edit_user() doesn't need to import the $wpdb global
• wp_list_widgets() doesn't need to import the $sidebars_widgets global
• switch/endswitch syntax is not supported in Hack
• A <ul> in wp-admin/users.php is unclosed

See #27881.

File:

• trunk/src/wp-admin/update-core.php (modified) (2 diffs)

trunk/src/wp-admin/update-core.php

@@ -364 +364 @@
     global $wp_filesystem;
 
-    include_once ABSPATH . 'wp-admin/includes/class-wp-upgrader.php';
+    include_once( ABSPATH . 'wp-admin/includes/class-wp-upgrader.php' );
 
     if ( $reinstall )
@@ -583 +583 @@
     echo '<div class="wrap">';
     echo '<h2>' . esc_html__('Update Plugins') . '</h2>';
-    echo "<iframe src='$url' style='width: 100%; height: 100%; min-height: 750px;' frameborder='0'></iframe>";
+    echo '<iframe src="', $url, '" style="width: 100%; height: 100%; min-height: 750px;" frameborder="0"></iframe>';
     echo '</div>';
     include(ABSPATH . 'wp-admin/admin-footer.php');