Changeset 28530

Timestamp:

05/19/2014 05:09:42 PM (11 years ago)

Author:

wonderboymusic

Message:

hackificator doesn't like mixed single/double-quoted attributes. These were 2 lingering instances in the admin.

See #27881.

Location:

trunk/src/wp-admin

Files:

• options.php (modified) (1 diff)
• update-core.php (modified) (1 diff)

trunk/src/wp-admin/options.php

@@ -231 +231 @@
     }
     $name = esc_attr( $option->option_name );
-    echo "
+    ?>
 <tr>
-    <th scope='row'><label for='$name'>" . esc_html( $option->option_name ) . "</label></th>
-<td>";
-    if ( strpos( $value, "\n" ) !== false )
-        echo "<textarea class='$class' name='$name' id='$name' cols='30' rows='5'>" . esc_textarea( $value ) . "</textarea>";
-    else
-        echo "<input class='regular-text $class' type='text' name='$name' id='$name' value='" . esc_attr( $value ) . "'" . disabled( $disabled, true, false ) . " />";
-    echo "</td>
-</tr>";
-endforeach;
-?>
+    <th scope="row"><label for="<?php echo $name ?>"><?php echo esc_html( $option->option_name ); ?></label></th>
+<td>
+<?php if ( strpos( $value, "\n" ) !== false ) : ?>
+    <textarea class="<?php echo $class ?>" name="<?php echo $name ?>" id="<?php echo $name ?>" cols="30" rows="5"><?php
+        echo esc_textarea( $value );
+    ?></textarea>
+    <?php else: ?>
+        <input class="regular-text <?php echo $class ?>" type="text" name="<?php echo $name ?>" id="<?php echo $name ?>" value="<?php echo esc_attr( $value ) ?>"<?php disabled( $disabled, true ) ?> />
+    <?php endif ?></td>
+</tr>
+<?php endforeach; ?>
   </table>
 

trunk/src/wp-admin/update-core.php

@@ -609 +609 @@
 
     require_once(ABSPATH . 'wp-admin/admin-header.php');
-    echo '<div class="wrap">';
-    echo '<h2>' . esc_html__('Update Themes') . '</h2>';
-    echo "<iframe src='$url' style='width: 100%; height: 100%; min-height: 750px;' frameborder='0'></iframe>";
-    echo '</div>';
+    ?>
+    <div class="wrap">
+        <h2><?php echo esc_html__('Update Themes') ?></h2>
+        <iframe src="<?php echo $url ?>" style="width: 100%; height: 100%; min-height: 750px;" frameborder="0"></iframe>
+    </div>
+    <?php
     include(ABSPATH . 'wp-admin/admin-footer.php');