Changeset 28543

Timestamp:

05/22/2014 06:50:11 PM (11 years ago)

Author:

SergeyBiryukov

Message:

Remove unnecessary array_reverse() from wp_get_post_revisions().

WP_Query properly handles multiple 'orderby' values since [28541].

fixes #26042.

Location:

trunk

Files:

• src/wp-includes/revision.php (modified) (2 diffs)
• tests/phpunit/tests/post/revisions.php (modified) (1 diff)

trunk/src/wp-includes/revision.php

@@ -418 +418 @@
         return array();
 
-    $defaults = array( 'order' => 'ASC', 'orderby' => 'date ID', 'check_enabled' => true );
+    $defaults = array( 'order' => 'DESC', 'orderby' => 'date ID', 'check_enabled' => true );
     $args = wp_parse_args( $args, $defaults );
 
@@ -428 +428 @@
     if ( ! $revisions = get_children( $args ) )
         return array();
-
-    $revisions = array_reverse( $revisions ); 
 
     return $revisions;

trunk/tests/phpunit/tests/post/revisions.php

@@ -354 +354 @@
         remove_filter( 'query', array( $this, '_filter_query' ) );
         global $wpdb;
-        $this->assertContains( "ORDER BY $wpdb->posts.post_date ASC, $wpdb->posts.ID ASC", $sql );
+        $this->assertContains( "ORDER BY $wpdb->posts.post_date DESC, $wpdb->posts.ID DESC", $sql );
         return $sql;
     }