Changeset 28561 for trunk/src/wp-admin/includes/template.php

Timestamp:

05/23/2014 07:28:45 PM (11 years ago)

Author:

wonderboymusic

Message:

In get_terms_to_edit(), call get_object_term_cache() before priming cache with wp_get_object_terms().

In get_inline_data(), do the same.

On list table screens with taxonomies in the admin, this dramatically reduces the number of database queries (3x less). Even more so with a persistent object cache (5x less).

Props johnbillion, jeffstieler, wonderboymusic.
Fixes #18968.

File:

• trunk/src/wp-admin/includes/template.php (modified) (1 diff)

trunk/src/wp-admin/includes/template.php

@@ -365 +365 @@
 
         if ( $taxonomy->hierarchical && $taxonomy->show_ui ) {
-                echo '<div class="post_category" id="' . $taxonomy_name . '_' . $post->ID . '">'
-                    . implode( ',', wp_get_object_terms( $post->ID, $taxonomy_name, array( 'fields' => 'ids' ) ) ) . '</div>';
+
+            $terms = get_object_term_cache( $post->ID, $taxonomy_name );
+            if ( false === $terms ) {
+                $terms = wp_get_object_terms( $post->ID, $taxonomy_name );
+                wp_cache_add( $post->ID, $terms, $taxonomy_name . '_relationships' );
+            }
+            $term_ids = empty( $terms ) ? array() : wp_list_pluck( $terms, 'term_id' );
+
+            echo '<div class="post_category" id="' . $taxonomy_name . '_' . $post->ID . '">' . implode( ',', $term_ids ) . '</div>';
+
         } elseif ( $taxonomy->show_ui ) {
+
             echo '<div class="tags_input" id="'.$taxonomy_name.'_'.$post->ID.'">'
                 . esc_html( str_replace( ',', ', ', get_terms_to_edit( $post->ID, $taxonomy_name ) ) ) . '</div>';
+
         }
     }