Changeset 28613

Timestamp:

05/29/2014 06:03:15 AM (11 years ago)

Author:

wonderboymusic

Message:

If post__in or post_parent__in is passed to WP_Query as an empty array, nuke the query. Both vars are currently only checked for truthiness after which they are ignored. Setting these vars at all indicates explicit filtering being desired.

Adds unit test.

Fixes #28099.

Location:

trunk

Files:

• src/wp-includes/query.php (modified) (2 diffs)
• tests/phpunit/tests/query/results.php (modified) (1 diff)

trunk/src/wp-includes/query.php

@@ -2449 +2449 @@
             $post__in = implode(',', array_map( 'absint', $q['post__in'] ));
             $where .= " AND {$wpdb->posts}.ID IN ($post__in)";
+        } elseif ( isset( $this->query['post__in'] ) ) {
+            $post__in = 0;
+            $where .= " AND 1=0 ";
         } elseif ( $q['post__not_in'] ) {
             $post__not_in = implode(',',  array_map( 'absint', $q['post__not_in'] ));
@@ -2459 +2462 @@
             $post_parent__in = implode( ',', array_map( 'absint', $q['post_parent__in'] ) );
             $where .= " AND {$wpdb->posts}.post_parent IN ($post_parent__in)";
+        } elseif ( isset( $this->query['post_parent__in'] ) ) {
+            $post_parent__in = 0;
+            $where .= " AND 1=0 ";
         } elseif ( $q['post_parent__not_in'] ) {
             $post_parent__not_in = implode( ',',  array_map( 'absint', $q['post_parent__not_in'] ) );

trunk/tests/phpunit/tests/query/results.php

@@ -403 +403 @@
     }
 
+    function test_empty_post__in() {
+        $posts1 = $this->q->query( array() );
+        $this->assertNotEmpty( $posts1 );
+        $posts2 = $this->q->query( array( 'post__in' => array() ) );
+        $this->assertEmpty( $posts2 );
+        $posts3 = $this->q->query( array( 'post_parent__in' => array() ) );
+        $this->assertEmpty( $posts3 );
+    }
+
     function test_exlude_from_search_empty() {
         global $wp_post_types;