WordPress.org

Make WordPress Core


Ignore:
Timestamp:
05/29/2014 06:03:15 AM (7 years ago)
Author:
wonderboymusic
Message:

If post__in or post_parent__in is passed to WP_Query as an empty array, nuke the query. Both vars are currently only checked for truthiness after which they are ignored. Setting these vars at all indicates explicit filtering being desired.

Adds unit test.

Fixes #28099.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/query/results.php

    r27686 r28613  
    403403    }
    404404
     405    function test_empty_post__in() {
     406        $posts1 = $this->q->query( array() );
     407        $this->assertNotEmpty( $posts1 );
     408        $posts2 = $this->q->query( array( 'post__in' => array() ) );
     409        $this->assertEmpty( $posts2 );
     410        $posts3 = $this->q->query( array( 'post_parent__in' => array() ) );
     411        $this->assertEmpty( $posts3 );
     412    }
     413
    405414    function test_exlude_from_search_empty() {
    406415        global $wp_post_types;
Note: See TracChangeset for help on using the changeset viewer.