Changeset 28736

Timestamp:

06/11/2014 05:40:11 PM (12 years ago)

Author:

wonderboymusic

Message:

Don't use variable variables in get_terms().

See #27881.

File:

• trunk/src/wp-includes/taxonomy.php (modified) (1 diff)

trunk/src/wp-includes/taxonomy.php

@@ -1572 +1572 @@
          */
         $clauses = apply_filters( 'terms_clauses', compact( $pieces ), $taxonomies, $args );
-        foreach ( $pieces as $piece ) {
-                $$piece = isset( $clauses[ $piece ] ) ? $clauses[ $piece ] : '';
-        }
+        $fields = isset( $clauses[ 'fields' ] ) ? $clauses[ 'fields' ] : '';
+        $join = isset( $clauses[ 'join' ] ) ? $clauses[ 'join' ] : '';
+        $where = isset( $clauses[ 'where' ] ) ? $clauses[ 'where' ] : '';
+        $orderby = isset( $clauses[ 'orderby' ] ) ? $clauses[ 'orderby' ] : '';
+        $order = isset( $clauses[ 'order' ] ) ? $clauses[ 'order' ] : '';
+        $limits = isset( $clauses[ 'limits' ] ) ? $clauses[ 'limits' ] : '';
+
         $query = "SELECT $fields FROM $wpdb->terms AS t $join WHERE $where $orderby $order $limits";