Changeset 28738 for trunk/src/wp-includes/comment.php

Timestamp:

06/11/2014 05:57:39 PM (12 years ago)

Author:

wonderboymusic

Message:

Don't use variable variables in WP_Comment_Query::query().

See #27881.

File:

• trunk/src/wp-includes/comment.php (modified) (1 diff)

trunk/src/wp-includes/comment.php

@@ -444 +444 @@
                  */
                 $clauses = apply_filters_ref_array( 'comments_clauses', array( compact( $pieces ), &$this ) );
-                foreach ( $pieces as $piece )
-                        $$piece = isset( $clauses[ $piece ] ) ? $clauses[ $piece ] : '';
+
+                $fields = isset( $clauses[ 'fields' ] ) ? $clauses[ 'fields' ] : '';
+                $join = isset( $clauses[ 'join' ] ) ? $clauses[ 'join' ] : '';
+                $where = isset( $clauses[ 'where' ] ) ? $clauses[ 'where' ] : '';
+                $orderby = isset( $clauses[ 'orderby' ] ) ? $clauses[ 'orderby' ] : '';
+                $order = isset( $clauses[ 'order' ] ) ? $clauses[ 'order' ] : '';
+                $limits = isset( $clauses[ 'limits' ] ) ? $clauses[ 'limits' ] : '';
+                $groupby = isset( $clauses[ 'groupby' ] ) ? $clauses[ 'groupby' ] : '';
 
                 if ( $groupby ) {