Changeset 28741 for trunk/src/wp-includes/pluggable.php

Timestamp:

06/11/2014 06:35:42 PM (11 years ago)

Author:

wonderboymusic

Message:

Don't use variable variables in wp_salt().

See #27881.

File:

• trunk/src/wp-includes/pluggable.php (modified) (3 diffs)

trunk/src/wp-includes/pluggable.php

@@ -1774 +1774 @@
         foreach ( array( 'AUTH', 'SECURE_AUTH', 'LOGGED_IN', 'NONCE', 'SECRET' ) as $first ) {
             foreach ( array( 'KEY', 'SALT' ) as $second ) {
-                if ( ! defined( "{$first}_{$second}" ) )
+                if ( ! defined( "{$first}_{$second}" ) ) {
                     continue;
+                }
                 $value = constant( "{$first}_{$second}" );
                 $duplicated_keys[ $value ] = isset( $duplicated_keys[ $value ] );
@@ -1782 +1783 @@
     }
 
-    $key = $salt = '';
-    if ( defined( 'SECRET_KEY' ) && SECRET_KEY && empty( $duplicated_keys[ SECRET_KEY ] ) )
-        $key = SECRET_KEY;
-    if ( 'auth' == $scheme && defined( 'SECRET_SALT' ) && SECRET_SALT && empty( $duplicated_keys[ SECRET_SALT ] ) )
-        $salt = SECRET_SALT;
+    $values = array(
+        'key' => '',
+        'salt' => ''
+    );
+    if ( defined( 'SECRET_KEY' ) && SECRET_KEY && empty( $duplicated_keys[ SECRET_KEY ] ) ) {
+        $values['key'] = SECRET_KEY;
+    }
+    if ( 'auth' == $scheme && defined( 'SECRET_SALT' ) && SECRET_SALT && empty( $duplicated_keys[ SECRET_SALT ] ) ) {
+        $values['salt'] = SECRET_SALT;
+    }
 
     if ( in_array( $scheme, array( 'auth', 'secure_auth', 'logged_in', 'nonce' ) ) ) {
@@ -1792 +1798 @@
             $const = strtoupper( "{$scheme}_{$type}" );
             if ( defined( $const ) && constant( $const ) && empty( $duplicated_keys[ constant( $const ) ] ) ) {
-                $$type = constant( $const );
-            } elseif ( ! $$type ) {
-                $$type = get_site_option( "{$scheme}_{$type}" );
-                if ( ! $$type ) {
-                    $$type = wp_generate_password( 64, true, true );
-                    update_site_option( "{$scheme}_{$type}", $$type );
+                $values[ $type ] = constant( $const );
+            } elseif ( ! $values[ $type ] ) {
+                $values[ $type ] = get_site_option( "{$scheme}_{$type}" );
+                if ( ! $values[ $type ] ) {
+                    $values[ $type ] = wp_generate_password( 64, true, true );
+                    update_site_option( "{$scheme}_{$type}", $values[ $type ] );
                 }
             }
         }
     } else {
-        if ( ! $key ) {
-            $key = get_site_option( 'secret_key' );
-            if ( ! $key ) {
-                $key = wp_generate_password( 64, true, true );
-                update_site_option( 'secret_key', $key );
+        if ( ! $values['key'] ) {
+            $values['key'] = get_site_option( 'secret_key' );
+            if ( ! $values['key'] ) {
+                $values['key'] = wp_generate_password( 64, true, true );
+                update_site_option( 'secret_key', $values['key'] );
             }
         }
-        $salt = hash_hmac( 'md5', $scheme, $key );
-    }
-
-    $cached_salts[ $scheme ] = $key . $salt;
+        $values['salt'] = hash_hmac( 'md5', $scheme, $values['key'] );
+    }
+
+    $cached_salts[ $scheme ] = $values['key'] . $values['salt'];
 
     /** This filter is documented in wp-includes/pluggable.php */