Changeset 28746

Timestamp:

06/11/2014 07:59:18 PM (10 years ago)

Author:

wonderboymusic

Message:

Don't use variable variables in wp_reset_vars(). Test by searching in list tables, etc.

See #27881.

File:

• trunk/src/wp-admin/includes/misc.php (modified) (1 diff)

trunk/src/wp-admin/includes/misc.php

@@ -275 +275 @@
  */
 function wp_reset_vars( $vars ) {
-    for ( $i=0; $i<count( $vars ); $i += 1 ) {
-        $var = $vars[$i];
-        global $$var;
-
-        if ( empty( $_POST[$var] ) ) {
-            if ( empty( $_GET[$var] ) )
-                $$var = '';
-            else
-                $$var = $_GET[$var];
+    foreach ( $vars as $var ) {
+        if ( empty( $_POST[ $var ] ) ) {
+            if ( empty( $_GET[ $var ] ) ) {
+                $GLOBALS[ $var ] = '';
+            } else {
+                $GLOBALS[ $var ] = $_GET[ $var ];
+            }
         } else {
-            $$var = $_POST[$var];
+            $GLOBALS[ $var ] = $_POST[ $var ];
         }
     }